Fixing depricated constants in HA 2024.1 #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed depricated constants (HA 2024.1)
fix depricated constants (HA 2024.1)
fix depricated constants (HA 2024.1)
Update const.py
Update number.py
Update sensor.py
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
thanks... I've changed it just to be sure. |
fixed a typo and combined constant import.
|
HA now starts without warnings |
|
I just replaced the 3 files and can confirm that after restarting HA no more errors are showing up. Great job. Thanks. |
Owner
|
Based on a quick review of the changes and the supporting tests done by @blauerreiter and @iot-werkstatt i'm gonna merge and release these changes as a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should address issue #154
please run some tests before merging, since I do not have any victron installed so far and therefore cannot do tests,