Usability Improvement: Improved naming for devices, entities and states + Multi-Language support (DE for now)

[jwiesel]

Breaking change

No breaking change

Proposed change

Replace register names by wording used in Venus OS and enable multi-language support for Victron devices, entities and their states.

• Translations have been taken from Venus OS 3.5 as far as possible (GUI v2). Missing ones have been named/translated based on best guess. Source: https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_de.ts
• Major entity types which I could test in my setup have been translated to EN (default for everyone) and DE.
• For those which are not yet translated the former application logic still applies (using the register names with blanks instead of underscores)

Observations independant of this PR (will check/create separate tickets):

• Some entity states have enums in const.py, but still show numeric values. These will start working, when the enum works correctly (see also class ess_mode(Enum): Update required #320)
• entities of type "binary_sensor" are also created as "sensor" (duplicate entities)
• entities of type "button", "number", "select" and "switch" are only created as sensors (see also: Switch for generator start/stop disappeared #325 )

--> Translations have already been created for all entity types and duplicates (translations in type sensor) can be removed when the observations above are fixed.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: Add Entity Translations #310
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• The code has been formatted using Ruff (ruff format custom_components/victron)

[sfstar]

Why remove the config flow structure?

[jwiesel]

Hi @sfstar , thanks for reviewing and testing!
To my understanding the strings.json is not needed in custom integrations, as it is only a duplicate of translations/en.json. Therefore I removed it and did all updates in en.json.

[sfstar]

Thanks for your reply,

Based on the documentation and my vague recollection the strings.json was required to define the overall structure of the translations while the translations en.json / de.json etc contain the language specific values for those strings.
Have you seen any issues with the translations for the config flow / setup flow?

[sfstar]

Thank you for opening this PR and contributing your time to this project.
I will run your changes on my instance for a couple of days and if no issues arise (and feedback is processed) this PR can be merged.
I've enabled the actions to run, please resolve the validation / ruff findings so that this pr can be merged.

[jwiesel]

Thanks for testing!
If you are missing entity types (e.g. charger, inverter, temperature sensor), please let me know. I can add these translations for review as well.

[jwiesel]

@sfstar : I just fixed the findings of hassfest and ruff. I can have another look after your next approval. :-)

[sfstar]

Great I've approved the worklows to run so that all findings can be verified.

[sfstar]

Regarding the hassfest finding.
I believe you copied the naming for the translation keys from the const.py.
the actual entity id that are registered show up as lower case.
For example:
victron_grid_l1_current_30
instead of
victron_grid_L1_current (from const.py).
Could your resolve this finding? (by renaming the entity keys in the en/de json files to lower case)

I will be able to further look at this PR coming wednesday.
Since it's otherwise an relatively long time to wait for an review (from sunday to sunday).
No hurries, just information so you know what you can expect regarding review follow-up ;)

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days