Skip to content

Conversation

@MatthiasOs
Copy link

Hey, thanks for the project.
I just used the instructions from "Manual" to successfully integrate victron data into home assistant.

In this PR

Update README.md:

  • clarified the manual installation
  • corrected some typos

Breaking change

No Breaking changes.

Proposed change

Update Readme

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

No additional information.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format custom_components/victron)

@MatthiasOs
Copy link
Author

It looks like i cant set the label myself, to pass the github check.
"documentation" would be the most fitting.

Copy link
Owner

@sfstar sfstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @MatthiasOs

@sfstar sfstar added the documentation Solely about the documentation of the project. label Jul 2, 2025
@sfstar
Copy link
Owner

sfstar commented Jul 2, 2025

Merging with ruff failure ignoring due to PR only having documentation / readme changes.

@sfstar sfstar merged commit 94a3bd5 into sfstar:main Jul 2, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Solely about the documentation of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants