Skip to content

Conversation

@julesxxl
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format custom_components/victron)

@julesxxl
Copy link
Collaborator Author

@sfstar : I've been working a lot to make it reliable to HA integrations submission. It doesn't fully work. But it is there, saved. So one day, one can correct the few things lacking.

@sfstar
Copy link
Owner

sfstar commented Aug 26, 2025

Hello @julesxxl,

Thank you for opening the PR.
Could you tell me the things that aren't fully working in this release?
As well as, do you want to improve on this pr further or is it meant as an hand-off (i.e. can it be merged an then improved upon in further commits?)

@julesxxl
Copy link
Collaborator Author

I'm not ready. I finally close it. I'll try to work on in a little bit more...

@julesxxl julesxxl closed this Aug 30, 2025
@sfstar
Copy link
Owner

sfstar commented Aug 31, 2025

Thank you for your continued help on this repository.
If you have something that is review ready or want to discus something let me know.
Trying to at least check this repository weekly the coming period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants