Skip to content

remove 3 of the new registers since they seem to report garbage values #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfstar merged 2 commits into from
Nov 16, 2025
Merged

remove 3 of the new registers since they seem to report garbage values #393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1565af5
remove 3 of the new registers since they seem to report garbage values
sfstar Nov 16, 2025
7ebbc99
fix ruff findings
sfstar Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions custom_components/victron/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,8 @@ class battery_mode(Enum):
dataType=UINT16,
entityType=TextReadEntityType(generic_alarm_ledger),
),
"battery_mode": RegisterInfo(327, UINT16, entityType=SelectWriteType(battery_mode)),
# disabled for now as it is specified as RESERVED (not yet active) in the documentation
# "battery_mode": RegisterInfo(327, UINT16, entityType=SelectWriteType(battery_mode)),
}

battery_registers_2 = {
Expand Down Expand Up @@ -1073,9 +1074,9 @@ class battery_balancer_status(Enum):
}

battery_info_registers = {
"battery_mode_2": RegisterInfo(
1319, UINT16, entityType=SelectWriteType(battery_mode_alternative)
),
# "battery_mode_2": RegisterInfo(
# 1319, UINT16, entityType=SelectWriteType(battery_mode_alternative)
# ),
"battery_balancer_status": RegisterInfo(
1320, UINT16, entityType=TextReadEntityType(battery_balancer_status)
),
Expand All @@ -1094,7 +1095,7 @@ class battery_balancer_status(Enum):
"battery_errors_smartlithium_invalidconfiguration": RegisterInfo(
1324, UINT16
), # This has no decode values for returned numbers
"battery_connection_information": RegisterInfo(1328, STRING(8)),
# "battery_connection_information": RegisterInfo(1328, STRING(8)),
}


Expand Down Expand Up @@ -3672,5 +3673,4 @@ class system_battery_state(Enum):
"system_invertercharger_registers": system_invertercharger_registers,
"system_pvac_registers": system_pvac_registers,
"system_power_registers_2": system_power_registers_2,

}
Loading