Skip to content

Change volume class to volume storage #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfstar merged 2 commits into from
May 5, 2023
Merged

Change volume class to volume storage #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f08c0a
Change volume class to volume storage since tank etc entities are sto…
May 5, 2023
b4f7c94
attempt to fix hassfest by sorting manifest keys
May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions custom_components/victron/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"domain": "victron",
"name": "victron",
"codeowners": [
"@sfstar"
],
"config_flow": true,
"integration_type": "hub",
"dependencies": [],
"documentation": "https://github.com/sfstar/hass-victron",
"homekit": {},
"integration_type": "hub",
"iot_class": "local_polling",
"issue_tracker": "https://github.com/sfstar/hass-victron/issues",
"requirements": [
"pymodbus==3.1.1"
],
"ssdp": [],
"zeroconf": [],
"homekit": {},
"dependencies": [],
"codeowners": [
"@sfstar"
],
"iot_class": "local_polling",
"version": "0.0.1"
"version": "0.0.11",
"zeroconf": []
}
2 changes: 1 addition & 1 deletion custom_components/victron/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def determine_victron_device_class(name, unit):
elif unit in [member.value for member in UnitOfTemperature]:
return SensorDeviceClass.TEMPERATURE
elif unit in [member.value for member in UnitOfVolume]:
return SensorDeviceClass.VOLUME # Perhaps change this to water if only water is measured in volume units
return SensorDeviceClass.VOLUME_STORAGE # Perhaps change this to water if only water is measured in volume units
elif unit in [member.value for member in UnitOfSpeed]:
if "meteo" in name:
return SensorDeviceClass.WIND_SPEED
Expand Down