added simple query implementation #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiaoying
reviewed
Nov 3, 2022
connectorx/src/get_arrow2.rs
Outdated
| let dispatcher = Dispatcher::< | ||
| _, | ||
| _, | ||
| PostgresArrowTransport<SimpleProtocol, MakeTlsConnector>, |
Contributor
There was a problem hiding this comment.
This transport should be PostgresArrow2Transport, the same applies to the below one. This is the reason for the ci failure.
Contributor
Author
There was a problem hiding this comment.
fixed it. code compiles now
wangxiaoying
requested changes
Nov 4, 2022
Contributor
wangxiaoying
left a comment
wangxiaoying
left a comment
There was a problem hiding this comment.
- format code
- need to add simple protocol support for pandas too at here
Contributor
Author
just made the changes requested @wangxiaoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new PR addressing issues in this previous PR: #322