Skip to content

Conversation

@Jordan-M-Young
Copy link
Contributor

@Jordan-M-Young Jordan-M-Young commented May 20, 2023

The goal of this PR is to extend support for the _text type as requested by a user within the issue: #480. This issue centers around connectorx panicking when interacting with tables containing a text[] type.

To solve this, I added:

  • a TextArray type in the various enums in connectorx/src/sources/postgres/typesystem.rs
  • a mapping between TextArray and Utf8Array in connectorx/src/transports/postgres_arrow2.rs
  • added _text/text[] data to scripts/postgres.sql
  • added a test for _text/text[] compatibility with postgres/polars in connectorx/tests/test_polars.rs

@Jordan-M-Young Jordan-M-Young changed the title Feat/add support for text Feat/add support for _text May 20, 2023
@Jordan-M-Young
Copy link
Contributor Author

@wangxiaoying Would you mind taking a look at this when you have a chance?

@wangxiaoying wangxiaoying merged commit b4e3294 into sfu-db:main Jun 6, 2023
@wangxiaoying
Copy link
Contributor

Hi @Jordan-M-Young , sorry for the late reply. Thanks for the PR! It looks good to me, I will try to make an alpha release for it by this weeken.

@Jordan-M-Young
Copy link
Contributor Author

@wangxiaoying No worries! Thanks for merging this!

@davidjbrennan
Copy link

Really appreciate you having done this @Jordan-M-Young. Works perfectly.

@Jordan-M-Young
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants