Skip to content

fix the log expression of clean df on clean gui #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

qidanrui
Copy link
Contributor

@qidanrui qidanrui commented Feb 24, 2022

Description

fix the log expression of clean df on clean gui

Snapshots:

Screen Shot 2022-02-24 at 10 14 06 AM

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #839 (62448aa) into develop (482ca40) will decrease coverage by 0.53%.
The diff coverage is 14.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #839      +/-   ##
===========================================
- Coverage    55.32%   54.78%   -0.54%     
===========================================
  Files          293      293              
  Lines        18993    19230     +237     
===========================================
+ Hits         10507    10536      +29     
- Misses        8486     8694     +208     
Impacted Files Coverage Δ
dataprep/clean/clean_url.py 97.84% <ø> (ø)
dataprep/clean/gui/clean_gui.py 11.53% <0.00%> (-9.19%) ⬇️
dataprep/clean/utils.py 40.00% <ø> (ø)
dataprep/eda/create_diff_report/__init__.py 50.00% <0.00%> (ø)
dataprep/eda/create_diff_report/diff_formatter.py 16.58% <0.00%> (ø)
dataprep/eda/utils.py 82.23% <0.00%> (ø)
dataprep/__init__.py 100.00% <100.00%> (ø)
dataprep/clean/clean_date.py 83.93% <100.00%> (ø)
dataprep/eda/correlation/compute/univariate.py 98.71% <100.00%> (ø)
dataprep/eda/correlation/render.py 98.69% <100.00%> (+0.02%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f79ed...62448aa. Read the comment docs.

@qidanrui qidanrui merged commit 7e60e9b into develop Feb 24, 2022
@qidanrui qidanrui deleted the fix_clean_df_log branch February 24, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant