Skip to content

Add clean functions in the selection UI #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

yixuy
Copy link
Collaborator

@yixuy yixuy commented Mar 10, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Add more functions( all in the document of the clean module) in the front-end selection field.
Reference:
https://github.com/sfu-db/dataprep/blob/develop/docs/source/api_reference/dataprep.clean.rst

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

image

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yixuy yixuy added type: enhancement New feature or request module: Cleaning javascript Pull requests that update Javascript code labels Mar 10, 2022
@yixuy yixuy self-assigned this Mar 10, 2022
@yixuy yixuy requested a review from qidanrui March 10, 2022 09:59
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #847 (282a58c) into develop (482ca40) will decrease coverage by 0.54%.
The diff coverage is 14.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #847      +/-   ##
===========================================
- Coverage    55.32%   54.77%   -0.55%     
===========================================
  Files          293      293              
  Lines        18993    19230     +237     
===========================================
+ Hits         10507    10533      +26     
- Misses        8486     8697     +211     
Impacted Files Coverage Δ
dataprep/clean/clean_url.py 97.84% <ø> (ø)
dataprep/clean/gui/clean_gui.py 11.53% <0.00%> (-9.19%) ⬇️
dataprep/clean/utils.py 40.00% <ø> (ø)
dataprep/eda/create_diff_report/__init__.py 50.00% <0.00%> (ø)
dataprep/eda/create_diff_report/diff_formatter.py 16.58% <0.00%> (ø)
dataprep/eda/utils.py 82.23% <0.00%> (ø)
dataprep/__init__.py 100.00% <100.00%> (ø)
dataprep/clean/clean_date.py 83.93% <100.00%> (ø)
dataprep/eda/correlation/compute/univariate.py 98.71% <100.00%> (ø)
dataprep/eda/correlation/render.py 98.69% <100.00%> (+0.02%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e60e9b...282a58c. Read the comment docs.

@qidanrui qidanrui merged commit 5a727c2 into develop Mar 11, 2022
@qidanrui qidanrui deleted the Add-more-clean-function-in-ui branch March 11, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code module: Cleaning type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants