Skip to content

Disable hypothesis deadlines #336

Open
@eric-czech

Description

@eric-czech

I saw a one-off build failure today related to the hypothesis deadlines associated with each test: https://github.com/eric-czech/sgkit/runs/1275478210?check_suite_focus=true.

I believe these should be disabled by convention for our project. I say that because exceeding the 200ms default deadline is not something I've been able to reproduce and there is very little value in hypothesis failing a whole build because one test parameterized one way and run at one point in time on a VM took a little longer. We could increase the deadlines but I don't see much value in that since the execution times probably have some long tail and it would only be a matter of time before it happens with a higher threshold.

I think having a benchmark suite (https://github.com/pystatgen/sgkit/issues/68) is a better way to catch performance problems/regressions, even if we are not benefiting from hypothesis potentially finding parameterizations that are particularly slow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions