Skip to content

Coverage is less than 100% #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomwhite opened this issue Nov 12, 2020 · 0 comments · Fixed by #381
Closed

Coverage is less than 100% #380

tomwhite opened this issue Nov 12, 2020 · 0 comments · Fixed by #381
Assignees
Labels
bug Something isn't working process + tools

Comments

@tomwhite
Copy link
Collaborator

The check that coverage must be 100% stopped working at some point. I'm not sure if it's related to the numba jit coverage issue (see #77), but I think we should mark numba functions as no cover (since there doesn't seem to be a way of getting coverage for these functions, see nedbat/coveragepy#849).

We also need to reinstate the mechanism that fails the build if coverage is under 100%, and fix the places not being covered. I'll submit a patch to do all this.

@tomwhite tomwhite added bug Something isn't working process + tools labels Nov 12, 2020
@tomwhite tomwhite self-assigned this Nov 12, 2020
@tomwhite tomwhite mentioned this issue Nov 12, 2020
@mergify mergify bot closed this as completed in #381 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working process + tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant