Fix coverage #381
Merged
Fix coverage #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected this fails with |
|
Thanks @eric-czech, do the fixes look OK too? |
eric-czech
reviewed
Nov 12, 2020
sgkit/io/vcfzarr_reader.py
Outdated
| @@ -169,7 +169,7 @@ def _vcfzarr_to_dataset( | |||
| if "variants/ID" in vcfzarr: | |||
| variants_id = da.from_zarr(vcfzarr["variants/ID"]).astype(str) | |||
| else: | |||
| variants_id = None | |||
There was a problem hiding this comment.
Not worth testing this one?
There was a problem hiding this comment.
Refactored to cover this case (see pystatgen/sgkit@be7f5be)
Yep, the new tests look good to me. |
tomwhite
force-pushed
the
fix-coverage
branch
from
6b38be3 to
be7f5be
Compare
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
===========================================
+ Coverage 95.15% 100.00% +4.84%
===========================================
Files 31 31
Lines 2334 2223 -111
===========================================
+ Hits 2221 2223 +2
+ Misses 113 0 -113
Continue to review full report at Codecov.
|
|
Two approvals here @tomwhite, so merge as you see fit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #380, first by causing the build to fail (by adding the
--cov-fail-underpytest option) - I will then add a commit to fix the remaining coverage issues.