Add nogil to hwe njit #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
approved these changes
Sep 7, 2020
ravwojdyla
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
@eric-czech 🔥 have you been able to validate/benchmark this? Any numbers you can present? Is this related to our monthly chat?
Nope, haven't benchmarked it (not since the gwas-analysis project). I put it on this issue though, at the top: https://github.com/pystatgen/sgkit/issues/68
I had hacked this into the code I ran for UKB but it wasn't the HWE part that seemed to bottleneck on the GIL (that was just a plain stddev calculation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pystatgen/sgkit/issues/222