Skip to content

[Feature] Add alternative names for pp-size, tp-size, and dp-size #893

Closed

Description

@w013nad

Motivation

Probably a bit immature but I just had a meeting with a coworker to explain the options for sglang. I really don't want to say pp-size at work again......

Can we modify the options to include pipeline-parallel-size, tensor-parallel-size, and data-parallel-size like vLLM do? We can still keep the old ones for back compatibility.

Related resources

https://github.com/vllm-project/vllm/blob/main/vllm/engine/arg_utils.py

Activity

  1. zhyncs commented on Aug 2, 2024

    @zhyncs
    Contributor

    Make sense.

  2. self-assigned this
    on Aug 2, 2024
  3. merrymercy commented on Aug 3, 2024

    @merrymercy
    Collaborator

    @w013nad Could you contribute a PR to fix this?

  4. yichuan-w commented on Aug 5, 2024

    @yichuan-w
    Contributor

    @w013nad #941 supports that now

  5. added 3 commits that reference this issue on Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions