Skip to content

Fix triton args init - #1034

Merged
hnyls2002 merged 2 commits into
mainfrom
fix-triton-args
Aug 11, 2024
Merged

hnyls2002 merged 2 commits into
mainfrom
fix-triton-args

Conversation

@hnyls2002

Copy link
Copy Markdown
Collaborator

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

There is still confusion with fill_ids and seq_len, when chunked prefill mixed with decode.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002

hnyls2002 commented Aug 11, 2024 •

Copy link
Copy Markdown
Collaborator Author

It should fix #1032

@hnyls2002
hnyls2002 merged commit 7b6a533 into main Aug 11, 2024
@hnyls2002
hnyls2002 deleted the fix-triton-args branch August 11, 2024 19:11
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant