[BugFix] Fix AttributeError in eagle speculative decoding when bs != len(sampling_info)#23790
Open
lingebeng wants to merge 2 commits intosgl-project:mainfrom
Open
[BugFix] Fix AttributeError in eagle speculative decoding when bs != len(sampling_info)#23790lingebeng wants to merge 2 commits intosgl-project:mainfrom
lingebeng wants to merge 2 commits intosgl-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When I read the sglang's source code about speculative, I found something belows:
sglang/python/sglang/srt/speculative/eagle_info.py
Line 2 in 977830e
sglang/python/sglang/srt/speculative/eagle_info.py
Lines 273 to 278 in 977830e
from copy import copyshadowed the copy module, causingcopy.deepcopy()to raise AttributeError. Changed toimport copyto fix.Modifications
Only change
from copy import copytoimport copy, and I have found that no other copy in this file.So the change is safe.
cc @Ying1123 @merrymercy @hnyls2002 @Qiaolin-Yu