[tokenizer] Guard communicator handle_recv against stale messages#23804
Open
brucechanglongxu wants to merge 1 commit intosgl-project:mainfrom
Open
[tokenizer] Guard communicator handle_recv against stale messages#23804brucechanglongxu wants to merge 1 commit intosgl-project:mainfrom
brucechanglongxu wants to merge 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a race in tokenizer communicator receive handling. Late messages can arrive after watching-call cleanup; previously that path could append into cleared state and throw. I added a guard in handle_recv so it only processes messages when active watch state exists, plus a regression test that reproduces the late-message case and verifies no crash. Local test run: /usr/bin/python3 -m unittest discover -s test/registered/tokenizer -p test_tokenizer_communicator.py -v (pass).
Motivation
Fix a race in tokenizer communicator receive handling. Late messages can arrive after a watch call has already cleaned up internal state. Previously, that path could try to append into cleared state and throw.
Modifications
Accuracy Tests
Ran:
/usr/bin/python3 -m unittest discover -s test/registered/tokenizer -p test_tokenizer_communicator.py -vPass:
test_handle_recv_ignores_stale_message_after_watch_completes
Speed Tests and Profiling
Not applicable. This is a control-flow safety fix only.