Repository navigation
[Fix/Potential Bugs] Can not correctly import models in python/sglang/srt/models - #311
Merged
Merged
Conversation
Contributor
excecute example directly via python is ok. running with debuggy as in your stacktrace and got error but different than your stacktrace: Is debugpy doing something strange with paths? |
comaniac
reviewed
Mar 19, 2024
comaniac
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM. Is it possible to add a unit test to make sure we are at the good shape?
Contributor
|
I had a similar issue trying to run the LLaVA model, and this works for me! Thanks for the good work :) |
Collaborator
|
@comaniac @BabyChouSr Adding some unit tests will be ideal. We have some tests but they require GPUs to run. I am not sure how to make them work with GitHub CI. |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
vschandramourya
pushed a commit
to vschandramourya/sglang
that referenced
this pull request
Feb 3, 2026
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 30, 2026
…22.0% vs vLLM sgl-project#707), code 108.25 (+21.8%), fair-vs-voll within joint spread => the +22-25% lead is essentially ALL engine/placement/transport at equal k, adaptive-k share small-to-undetectable; sgl-project#311 FALSIFIED with reversed sign — fp8 draft is SLOWER (+4 to +12% ms/Verify vs bf16; bs=1 drafter is latency- not bandwidth-bound, per-step dequant adds cost; accept holds), bs=1 verdict hardens to -34 to -50%; side proofs: draft-quant flag verified not to reach target, extra reserve requirement belongs to high-accept ladder not AEON; harness gap: battery_release_locks is process-local, orphans locks from new shells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated with issue #310