Repository navigation
[AMD] Build Miles nightly ROCm images with docker/build.py and test ROCm 7.2 #31757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
66a42dd
d051557
022e46b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,50 +14,42 @@ jobs: | |
| if: github.repository == 'sgl-project/sglang' | ||
| runs-on: amd-docker-scale | ||
| environment: "prod" | ||
| permissions: | ||
| contents: read | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - gpu_arch: gfx950 | ||
| rocm_tag: rocm700-mi35x | ||
| sglang_image_repo: rocm/sgl-dev | ||
| sglang_image_tag: v0.5.14-rocm700-mi35x-20260627 | ||
| - gpu_arch: gfx942 | ||
| rocm_tag: rocm700-mi30x | ||
| sglang_image_tag: v0.5.10-rocm700-mi30x | ||
| variant: | ||
| - rocm700-mi35x | ||
| - rocm700-mi30x | ||
| steps: | ||
| - name: Checkout miles repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: radixark/miles | ||
| ref: main | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Record miles commit | ||
| run: echo "Building from miles main @ $(git rev-parse HEAD)" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P2] Keep this SHA pinned in the image build, rather than only printing it. The previous workflow passed this value as
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @XinyuJiangCMU could you please take a look at this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @bingxche, I tested the images build successfully. Since Miles updates are relatively infrequent compared with SGLang, I think the small potential drift is acceptable here, and I’d prefer to keep this aligned with the upstream build.py flow. |
||
|
|
||
| - name: Set date | ||
| run: echo "DATE=$(date +%Y%m%d)" >> $GITHUB_ENV | ||
|
|
||
| - name: Record miles commit | ||
| id: miles | ||
| run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT | ||
| - name: Install docker/build.py dependencies | ||
| run: python3 -m pip install --quiet typer | ||
|
|
||
| - name: Build image via miles docker/build.py and tag with date | ||
| run: | | ||
| python3 docker/build.py --variant ${{ matrix.variant }} --image-tag custom --custom-tag miles | ||
| docker tag rocm/sgl-dev:miles-${{ matrix.variant }} rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE} | ||
|
|
||
| - name: Login to Docker Hub (AMD) | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_AMD_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_AMD_TOKEN }} | ||
|
|
||
| - name: Build and push miles image to rocm/sgl-dev | ||
| run: | | ||
| base="miles-${{ matrix.rocm_tag }}" | ||
| dated="${base}-${{ env.DATE }}" | ||
| echo "IMAGE_TAG=${dated}" >> $GITHUB_ENV | ||
| echo "Building rocm/sgl-dev:${dated} from miles main @ ${{ steps.miles.outputs.sha }}" | ||
| docker build . \ | ||
| -f docker/Dockerfile.rocm \ | ||
| --build-arg GPU_ARCH=${{ matrix.gpu_arch }} \ | ||
| --build-arg SGLANG_IMAGE_REPO=${{ matrix.sglang_image_repo || 'lmsysorg/sglang' }} \ | ||
| --build-arg SGLANG_IMAGE_TAG=${{ matrix.sglang_image_tag }} \ | ||
| --build-arg MILES_COMMIT=${{ steps.miles.outputs.sha }} \ | ||
| -t rocm/sgl-dev:${dated} \ | ||
| --no-cache | ||
| docker push rocm/sgl-dev:${dated} | ||
| - name: Push dated tag | ||
| run: docker push rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] Please confirm that dropping ROCm 7.0 runtime coverage is intentional. This rename replaces the only Miles ROCm 7.0 nightly test rather than adding a separate 7.2 workflow. Both ROCm 7.0 images will still be published, but neither will have a Miles runtime nightly after this merges. If ROCm 7.0 remains supported, please keep the existing workflow and add 7.2 separately; otherwise, documenting the coverage migration/deprecation in the PR description would make the tradeoff explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is intentional. Only ROCm 7.2 will have Miles nightly runtime coverage. I’ve updated the PR description accordingly.