Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Nightly Test Miles (AMD ROCm 7.0)
name: Nightly Test Miles (AMD ROCm 7.2)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Please confirm that dropping ROCm 7.0 runtime coverage is intentional. This rename replaces the only Miles ROCm 7.0 nightly test rather than adding a separate 7.2 workflow. Both ROCm 7.0 images will still be published, but neither will have a Miles runtime nightly after this merges. If ROCm 7.0 remains supported, please keep the existing workflow and add 7.2 separately; otherwise, documenting the coverage migration/deprecation in the PR description would make the tradeoff explicit.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional. Only ROCm 7.2 will have Miles nightly runtime coverage. I’ve updated the PR description accordingly.


on:
schedule:
Expand All @@ -7,7 +7,7 @@ on:
workflow_dispatch:
inputs:
image_tag:
description: "Override miles image tag (e.g. miles-rocm700-mi35x-20260621); empty = newest by date"
description: "Override miles image tag (e.g. miles-rocm720-mi35x-20260621); empty = newest by date"
required: false
type: string
default: ""
Expand Down Expand Up @@ -46,10 +46,10 @@ jobs:
username: ${{ secrets.DOCKERHUB_AMD_USERNAME }}
password: ${{ secrets.DOCKERHUB_AMD_TOKEN }}

- name: Resolve newest miles ROCm 7.0 image
- name: Resolve newest miles ROCm 7.2 image
run: |
repo="rocm/sgl-dev"
base="miles-rocm700-mi35x"
base="miles-rocm720-mi35x"
tag="${{ inputs.image_tag }}"
if [ -z "${tag}" ]; then
# Walk back from today; the build job pushes a dated tag at 12:00 UTC.
Expand Down
44 changes: 18 additions & 26 deletions .github/workflows/release-docker-amd-miles-rocm700-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,50 +14,42 @@ jobs:
if: github.repository == 'sgl-project/sglang'
runs-on: amd-docker-scale
environment: "prod"
permissions:
contents: read
strategy:
fail-fast: false
matrix:
include:
- gpu_arch: gfx950
rocm_tag: rocm700-mi35x
sglang_image_repo: rocm/sgl-dev
sglang_image_tag: v0.5.14-rocm700-mi35x-20260627
- gpu_arch: gfx942
rocm_tag: rocm700-mi30x
sglang_image_tag: v0.5.10-rocm700-mi30x
variant:
- rocm700-mi35x
- rocm700-mi30x
steps:
- name: Checkout miles repository
uses: actions/checkout@v4
with:
repository: radixark/miles
ref: main
fetch-depth: 0
persist-credentials: false

- name: Record miles commit
run: echo "Building from miles main @ $(git rev-parse HEAD)"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep this SHA pinned in the image build, rather than only printing it. The previous workflow passed this value as MILES_COMMIT and used --no-cache. Current upstream build.py does not pass MILES_COMMIT, while Dockerfile.rocm defaults it to main and clones Miles again. The image therefore is not guaranteed to contain the commit recorded here (and a cache-preserving builder can reuse an older clone layer under a new dated tag). Please have build.py derive/pass the checked-out HEAD or expose an override for it. The same issue applies to the ROCm 7.2 workflow.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XinyuJiangCMU could you please take a look at this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bingxche, I tested the images build successfully. Since Miles updates are relatively infrequent compared with SGLang, I think the small potential drift is acceptable here, and I’d prefer to keep this aligned with the upstream build.py flow.


- name: Set date
run: echo "DATE=$(date +%Y%m%d)" >> $GITHUB_ENV

- name: Record miles commit
id: miles
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
- name: Install docker/build.py dependencies
run: python3 -m pip install --quiet typer

- name: Build image via miles docker/build.py and tag with date
run: |
python3 docker/build.py --variant ${{ matrix.variant }} --image-tag custom --custom-tag miles
docker tag rocm/sgl-dev:miles-${{ matrix.variant }} rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE}

- name: Login to Docker Hub (AMD)
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_AMD_USERNAME }}
password: ${{ secrets.DOCKERHUB_AMD_TOKEN }}

- name: Build and push miles image to rocm/sgl-dev
run: |
base="miles-${{ matrix.rocm_tag }}"
dated="${base}-${{ env.DATE }}"
echo "IMAGE_TAG=${dated}" >> $GITHUB_ENV
echo "Building rocm/sgl-dev:${dated} from miles main @ ${{ steps.miles.outputs.sha }}"
docker build . \
-f docker/Dockerfile.rocm \
--build-arg GPU_ARCH=${{ matrix.gpu_arch }} \
--build-arg SGLANG_IMAGE_REPO=${{ matrix.sglang_image_repo || 'lmsysorg/sglang' }} \
--build-arg SGLANG_IMAGE_TAG=${{ matrix.sglang_image_tag }} \
--build-arg MILES_COMMIT=${{ steps.miles.outputs.sha }} \
-t rocm/sgl-dev:${dated} \
--no-cache
docker push rocm/sgl-dev:${dated}
- name: Push dated tag
run: docker push rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE}
38 changes: 17 additions & 21 deletions .github/workflows/release-docker-amd-miles-rocm720-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,45 +14,41 @@ jobs:
if: github.repository == 'sgl-project/sglang'
runs-on: amd-docker-scale
environment: "prod"
permissions:
contents: read
strategy:
fail-fast: false
matrix:
include:
- gpu_arch: gfx950
rocm_tag: rocm720-mi35x
sglang_image_tag: v0.5.10-rocm720-mi35x
variant:
- rocm720-mi35x
steps:
- name: Checkout miles repository
uses: actions/checkout@v4
with:
repository: radixark/miles
ref: main
fetch-depth: 0
persist-credentials: false

- name: Record miles commit
run: echo "Building from miles main @ $(git rev-parse HEAD)"

- name: Set date
run: echo "DATE=$(date +%Y%m%d)" >> $GITHUB_ENV

- name: Record miles commit
id: miles
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
- name: Install docker/build.py dependencies
run: python3 -m pip install --quiet typer

- name: Build image via miles docker/build.py and tag with date
run: |
python3 docker/build.py --variant ${{ matrix.variant }} --image-tag custom --custom-tag miles
docker tag rocm/sgl-dev:miles-${{ matrix.variant }} rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE}

- name: Login to Docker Hub (AMD)
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_AMD_USERNAME }}
password: ${{ secrets.DOCKERHUB_AMD_TOKEN }}

- name: Build and push miles image to rocm/sgl-dev
run: |
base="miles-${{ matrix.rocm_tag }}"
dated="${base}-${{ env.DATE }}"
echo "IMAGE_TAG=${dated}" >> $GITHUB_ENV
echo "Building rocm/sgl-dev:${dated} from miles main @ ${{ steps.miles.outputs.sha }}"
docker build . \
-f docker/Dockerfile.rocm \
--build-arg GPU_ARCH=${{ matrix.gpu_arch }} \
--build-arg SGLANG_IMAGE_TAG=${{ matrix.sglang_image_tag }} \
--build-arg MILES_COMMIT=${{ steps.miles.outputs.sha }} \
-t rocm/sgl-dev:${dated} \
--no-cache
docker push rocm/sgl-dev:${dated}
- name: Push dated tag
run: docker push rocm/sgl-dev:miles-${{ matrix.variant }}-${DATE}
Loading