Repository navigation
Conversation
yhyang201
merged commit Aug 28, 2026
639db13
into
sgl-project:qwen4-main-squashed
80 of 90 checks passed
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Transformers v5.16.1 normalizes Qwen4-Exp checkpoint layers from
full_attentiontoqwen_sparse_attention. Checkpoints re-saved with that version can therefore containqwen_sparse_attention.Qwen4ExpTextConfig.layers_block_typecurrently normalizes onlyfull_attention, leavingqwen_sparse_attentionto reach the decoder layer dispatch and raise aKeyError.Modifications
full_attentionandqwen_sparse_attentionto the runtimeattentionlayer type.Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #33137316255
Latest PR Test (Extra): ❌ Run #33137316077
Latest PR Test (AMD ROCm 7.2): ❌ Run #33137316183