Repository navigation
[AMD] Update ROCm AITER pin to 4ad9983 - #37784
Merged
Merged
Conversation
kangwangamd
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock,
sogalin and
yctseng0211
as code owners
September 3, 2026 10:50
This was referenced Sep 3, 2026
HaiShaw
approved these changes
Sep 7, 2026
5 tasks
This was referenced Sep 7, 2026
hdt98
pushed a commit
to hdt98/sglang
that referenced
this pull request
Sep 10, 2026
This was referenced Sep 10, 2026
This was referenced Sep 21, 2026
This was referenced Sep 29, 2026
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update the ROCm images from AITER c16d44b to ROCm/aiter@4ad9983. The new pin is 152 upstream commits ahead of the current default.
Modifications
Update AITER_COMMIT_DEFAULT for all eight gfx942/gfx950 ROCm image flavors. The gfx1250-rocm1000 stage tracks a separate AITER pin (a6d2b564) and is left unchanged.
Accuracy Tests
Not run locally; this Docker dependency update requires AMD GPU image/accuracy CI. Docker is not available in the local environment.
Speed Tests and Profiling
Not run as a gate. The #3 gsm8k timing A/B from the Scout logs shows the candidate is marginally faster (7.7% faster per model on the shared model set) — no regression.
Checklist
CI States
Latest PR Test (Base): ✅ Run #33746497479
Latest PR Test (Extra): ❌ Run #33746497454
Latest PR Test (AMD ROCm 7.2): ❌ Run #33746497519