Skip to content

[AMD] Update ROCm AITER pin to 4ad9983 - #37784

Merged
HaiShaw merged 1 commit into
sgl-project:mainfrom
kangwangamd:patch-2
Sep 7, 2026
Merged

HaiShaw merged 1 commit into
sgl-project:mainfrom
kangwangamd:patch-2

Conversation

@kangwangamd

@kangwangamd kangwangamd commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Update the ROCm images from AITER c16d44b to ROCm/aiter@4ad9983. The new pin is 152 upstream commits ahead of the current default.

Modifications

Update AITER_COMMIT_DEFAULT for all eight gfx942/gfx950 ROCm image flavors. The gfx1250-rocm1000 stage tracks a separate AITER pin (a6d2b564) and is left unchanged.

Accuracy Tests

Not run locally; this Docker dependency update requires AMD GPU image/accuracy CI. Docker is not available in the local environment.

Speed Tests and Profiling

Not run as a gate. The #3 gsm8k timing A/B from the Scout logs shows the candidate is marginally faster (7.7% faster per model on the shared model set) — no regression.

Checklist


CI States

Latest PR Test (Base): ✅ Run #33746497479
Latest PR Test (Extra): ❌ Run #33746497454
Latest PR Test (AMD ROCm 7.2): ❌ Run #33746497519

@HaiShaw
HaiShaw merged commit b9b39f2 into sgl-project:main Sep 7, 2026
119 of 125 checks passed
hdt98 pushed a commit to hdt98/sglang that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants