Skip to content

[Test] Fix optimistic prefill disaggregation test after mamba radix cache removal - #40469

Merged
ispobock merged 2 commits into
mainfrom
mmangkad/fix-optimistic-prefill-mamba-tree-cache
Sep 20, 2026
Merged

ispobock merged 2 commits into
mainfrom
mmangkad/fix-optimistic-prefill-mamba-tree-cache

Conversation

@mmangkad

@mmangkad mmangkad commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

#40313 deleted mem_cache/mamba_radix_cache.py but left this test importing it, so test_disaggregation_optimistic_prefill.py fails at import on main.

Migrates it to UnifiedRadixCache: tree_components=(FULL, MAMBA), root_node_handle() for the NodeId, and tree_core.get_component_device_value(...) for the node's mamba slot. Also restates a class docstring describing an is_insert mechanism that MambaComponent now absorbs internally.

Full file green on 2 GPUs: Ran 8 tests in 285.524s / OK.


CI States

Latest PR Test (Base): ❌ Run #35516633727
Latest PR Test (Extra): ❌ Run #35516633589
Latest PR Test (AMD ROCm 10): ❌ Run #35516633710

@mmangkad

Copy link
Copy Markdown
Contributor Author

/rerun-test test/registered/disaggregation/test_disaggregation_optimistic_prefill.py

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/disaggregation/test_disaggregation_optimistic_prefill.py:

🚀 2-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/disaggregation/test_disaggregation_optimistic_prefill.py

@ispobock
ispobock merged commit 8923f4d into main Sep 20, 2026
110 of 123 checks passed
@ispobock
ispobock deleted the mmangkad/fix-optimistic-prefill-mamba-tree-cache branch September 20, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants