Repository navigation
Make public APIs more standard. - #416
Merged
Merged
Conversation
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Garrybest
pushed a commit
to Garrybest/sglang
that referenced
this pull request
Jan 9, 2026
*skip flash attention kernel xai_temperature_len test
EdwardXuy
pushed a commit
to shun8686/sglang
that referenced
this pull request
Apr 23, 2026
Add offloading testcase
efschu
pushed a commit
to efschu/htsglang
that referenced
this pull request
Aug 14, 2026
Section 7 could push a tag and had nothing that looked at the result. sgl-project#416 is the precedent for why that is not enough: an image that built fine, pushed fine, and was wrong for the person who pulled it. The only check that catches that class is pulling the published artifact by tag with no local layers and no build context, and inspecting what it actually contains. 7.1 adds three: the provenance guard, the sgl-project#416 empty-flag behaviour itself, and the NCCL floor read from NCCL's own banner. Check (a) fails today on the already-published htsglang:cu130-nccl2307, which predates the guard, so that is written down as a precondition rather than left to be rediscovered -- whatever goes out next has to pass it before anything is announced. The apparmor requirement is recorded as covering every docker run in this LXC, not only the serving one; a trivial probe hit it first. The orphan-container VRAM trap is written down with the check that actually detects it, since docker ps alone does not show the container still holding the reservation.
efschu
pushed a commit
to efschu/htsglang
that referenced
this pull request
Aug 14, 2026
…es, and supersede the shadowed tag Closes the draft's own blocking item 2b. Every feature in FEATURES_VS_UPSTREAM.md now carries an evidence label with the figure quoted verbatim: measured when a run produced it, estimate when the document itself says it is not a measurement, absent when there is no defensible number. The tally is 16 measured, 1 estimate, 17 absent -- half the fork has no number, and those rows keep an empty number slot rather than an invented one. Two things the table forces the README to say out loud. Four rows carry figures that are not wins and would be overclaims if presented as gains: the cross-algorithm bandit LOSES to the static winner at 75.52 against 89.22 tok/s, session KV spill lands at 37.74 vs 37.92 ms per verify round which is inside the boot-to-boot band, per-message-class link selection lands inside its own control's spread and the document says it is not worth it on this rig, and both cross-rig PP and the prefill satellite are costs bought deliberately for capacity and for undisturbed decode. SWA-DCP's ~+6-10% is marked estimate and must never be quoted as measured -- the document calls it ex-ante. Every figure carries the lower-bound framing and the detection limit, because without them a number from this rig reads as a benchmark: raw tok/s has a 2.6-4.2% boot-to-boot spread against 0.09-0.85% for ms per verify round, so anything finer than ~3.5% belongs on the round-time axis and values inside the spread are not gains. The summary line above the table first said fourteen absent rows. It was seventeen. The count is now taken mechanically and the error is recorded in place, since a miscounted summary sitting above a correct table is exactly how an invented number enters a document written to keep them out. Checklist 7.0 makes superseding the published tag a mandatory pre-push step. The characterisation matters and the loose version is already circulating: the published cu130-nccl2307 is NOT armless. Two distributions provide sgl_kernel and the fork's armed files currently win, so the arm is present today. The defect is instability rather than absence -- pip reports no conflict, so the next install of either one silently decides which files win, and one candidate is armless. An image that is correct today and one pip install from being wrong is not shippable, which is why the guard treats a shadow as an error even with the arm present. The new build must take the tag, the new digest must be recorded, and the sgl-project#416-style verify must re-run against that digest by sha256 rather than by tag, since a tag can move between push and check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #386, trying to avoid using
import *, making all the public APIs more visible.