Repository navigation
[sglang-miles] [diffusion] fix: report the port each scheduler actually bound to its clients - #42470
Merged
Rockdu merged 1 commit intoOct 4, 2026
Conversation
…each scheduler actually bound to its clients Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu
marked this pull request as ready for review
October 4, 2026 19:57
Rockdu
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
kevin-mii,
mickqian,
niehen6174,
ping1jing2 and
yichiche
as code owners
October 4, 2026 19:57
nv-hwoo
pushed a commit
to nv-hwoo/sglang
that referenced
this pull request
Oct 20, 2026
…] fix: report the port each scheduler actually bound to its clients (sgl-project#42470) Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu
added a commit
that referenced
this pull request
Oct 30, 2026
…rt the port each scheduler actually bound to its clients (#42470) Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu
added a commit
that referenced
this pull request
Oct 30, 2026
…rt the port each scheduler actually bound to its clients (#42470) Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu
added a commit
that referenced
this pull request
Oct 31, 2026
…rt the port each scheduler actually bound to its clients (#42470) Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu
added a commit
that referenced
this pull request
Oct 31, 2026
…rt the port each scheduler actually bound to its clients (#42470) Signed-off-by: rockdu <kangrdu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port #42332 to the
sglang-milesbranch.Diffusion engines starting together on one host can pick the same scheduler port. The loser's scheduler binds
port + 42, but its HTTP side still connects to the guessed port, so its requests reach another engine's scheduler and GPU. Each scheduler now reports the port it actually bound in its ready message, and the launcher records it before any client connects.This is the intermittent
stage-c-5-gpu-h200failure in miles-diffusion CI:Port notes
Clean cherry-pick; the hunks are identical to #42332.
CI States
Latest PR Test (Base): ❌ Run #37187438012
Latest PR Test (Extra): ❌ Run #37187437856
Latest PR Test (AMD ROCm 10): ❌ Run #37187438007