Skip to content

[sglang-miles] [diffusion] fix: report the port each scheduler actually bound to its clients - #42470

Merged
Rockdu merged 1 commit into
sgl-project:sglang-milesfrom
Rockdu:fix/sgld-scheduler-port-race-sglang-miles
Oct 4, 2026
Merged

Rockdu merged 1 commit into
sgl-project:sglang-milesfrom
Rockdu:fix/sgld-scheduler-port-race-sglang-miles

Conversation

@Rockdu

@Rockdu Rockdu commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Port #42332 to the sglang-miles branch.

Diffusion engines starting together on one host can pick the same scheduler port. The loser's scheduler binds port + 42, but its HTTP side still connects to the guessed port, so its requests reach another engine's scheduler and GPU. Each scheduler now reports the port it actually bound in its ready message, and the launcher records it before any client connects.

This is the intermittent stage-c-5-gpu-h200 failure in miles-diffusion CI:

no payload was exported from this worker's GPU 47b7c7e8-..., got ['05a0fd7c-...']

Port notes

Clean cherry-pick; the hunks are identical to #42332.


CI States

Latest PR Test (Base): ❌ Run #37187438012
Latest PR Test (Extra): ❌ Run #37187437856
Latest PR Test (AMD ROCm 10): ❌ Run #37187438007

…each scheduler actually bound to its clients

Signed-off-by: rockdu <kangrdu@gmail.com>
@github-actions github-actions Bot added the diffusion SGLang Diffusion label Oct 4, 2026
@Rockdu
Rockdu marked this pull request as ready for review October 4, 2026 19:57
@Rockdu
Rockdu merged commit 4821446 into sgl-project:sglang-miles Oct 4, 2026
69 of 78 checks passed
@Rockdu Rockdu changed the title [cherrypick from #42332] [diffusion] fix: report the port each scheduler actually bound to its clients [sglang-miles] [diffusion] fix: report the port each scheduler actually bound to its clients Oct 4, 2026
nv-hwoo pushed a commit to nv-hwoo/sglang that referenced this pull request Oct 20, 2026
…] fix: report the port each scheduler actually bound to its clients (sgl-project#42470)

Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu added a commit that referenced this pull request Oct 30, 2026
…rt the port each scheduler actually bound to its clients (#42470)

Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu added a commit that referenced this pull request Oct 30, 2026
…rt the port each scheduler actually bound to its clients (#42470)

Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu added a commit that referenced this pull request Oct 31, 2026
…rt the port each scheduler actually bound to its clients (#42470)

Signed-off-by: rockdu <kangrdu@gmail.com>
Rockdu added a commit that referenced this pull request Oct 31, 2026
…rt the port each scheduler actually bound to its clients (#42470)

Signed-off-by: rockdu <kangrdu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant