Repository navigation
[Fix] diffusion: Cosmos3 Bug fixes - #43194
Merged
Merged
Conversation
kediwu0331
requested review from
AgainstEntropy,
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
JustinTong0323,
celve,
kevin-mii,
mickqian,
niehen6174,
ping1jing2,
sogalin,
wisclmy0611,
yichiche,
yuan-luo and
zijiexia
as code owners
October 8, 2026 20:07
Contributor
Author
|
@mickqian these are some fixes for cosmos3. Could you review? Thanks |
mickqian
approved these changes
Oct 19, 2026
Collaborator
|
/tag-and-rerun-ci |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Contributor
Author
|
@mickqian I added two more fixes. 3 is just a config fix for cosmos dreams. 4 is more general fix. I encountered this bug when I tested ulysses degree 8 for cosmos3 transfer auto. This issue will be triggered when there is only 1 kv head on a sp rank. Let me know if you are ok with the change. (ps. I think current test failure is not related to this PR. Could you help rerun the failed cases.) |
This was referenced Nov 1, 2026
Yuxingwang-intel
pushed a commit
to Yuxingwang-intel/sglang
that referenced
this pull request
Nov 6, 2026
Co-authored-by: Kedi Wu <kediw@nvidia.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Mick Qian <mickqian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes four issues:
Modifications
Accuracy Tests
Did parity test for action generation with sp > 1.
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #41222912562
Latest PR Test (Extra): ❌ Run #41222912354
Latest PR Test (AMD ROCm 10): ❌ Run #41222912548
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: