-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[Quant Kernel] refactored per token group quant fp8 to support int8 up-to 2x faster #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68c70e8
to
6f92123
Compare
BBuf
reviewed
Mar 14, 2025
a2cdb9f
to
9810175
Compare
9810175
to
acf67a1
Compare
08af2c0
to
1614cc4
Compare
BBuf
approved these changes
Mar 19, 2025
1614cc4
to
33b9f93
Compare
6d0ba94
to
d0cec50
Compare
d0cec50
to
7f32d00
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2965
The new cuda kernel accelerates 1x-2x compared to triton kernel. Refactored the fp8 kernel so it works for both fp8 and int8 output quantization types.
int8 precision issue: some cells diff by 1.
Combination triton # 1 & cuda # 1 with disabled "-use_fast_math" nvcc flag
Combination triton # 1 & cuda # 1 with enabled "-use_fast_math" nvcc flag
Tried 2 triton conversions
Tried 3 cuda conversions
Modifications
Checklist