Skip to content

[AMD][DSV4][8/8] gfx950 ROCm images: pin aiter to 57e2c6b42e #44035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkHuang-amd wants to merge 4 commits into from
Closed

[AMD][DSV4][8/8] gfx950 ROCm images: pin aiter to 57e2c6b42e #44035

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c88e6f5
[dsv4opt] Dockerfile: gfx950-rocm720/724 aiter pin -> ROCm/aiter main…
Duyi-Wang Oct 12, 2026
439cdd1
[AMD] aiter #6042 resolved patch: drop trailing whitespace
kkHuang-amd Oct 13, 2026
e0abcbd
Merge branch 'main' into amd/rocm-dockerfile-aiter-pin
kkHuang-amd Oct 15, 2026
b66e82a
[dsv4opt] Dockerfile: bump gfx950-rocm720/724 aiter pin to 57e2c6b42e…
kkHuang-amd Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions docker/rocm.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ ENV BUILD_TRITON="1"
ENV BUILD_LLVM="0"
ENV BUILD_AITER_ALL="1"
ENV BUILD_MOONCAKE="1"
ENV AITER_COMMIT_DEFAULT="e7d2453f25e5aaeea72a3a40b284ba453e026624"
# dsv4opt: official ROCm/aiter main 57e2c6b42e (2026-10-13, the #6042 merge); unmerged aiter PRs
# are carried in-tree in sglang (see the TODO(aiter#NNNN) markers).
ENV AITER_COMMIT_DEFAULT="57e2c6b42e17d926a6bb5378ce0d07d93520bd3f"
ENV TRITON_COMMIT_DEFAULT="42270451990532c67e69d753fbd026f28fcc4840"

# ===============================
Expand All @@ -127,7 +129,9 @@ ENV BUILD_TRITON="1"
ENV BUILD_LLVM="0"
ENV BUILD_AITER_ALL="1"
ENV BUILD_MOONCAKE="1"
ENV AITER_COMMIT_DEFAULT="e7d2453f25e5aaeea72a3a40b284ba453e026624"
# dsv4opt: official ROCm/aiter main 57e2c6b42e (2026-10-13, the #6042 merge); unmerged aiter PRs
# are carried in-tree in sglang (see the TODO(aiter#NNNN) markers).
ENV AITER_COMMIT_DEFAULT="57e2c6b42e17d926a6bb5378ce0d07d93520bd3f"
# Pin the ROCm torch stack for every pip invocation in this flavor. The file is
# filled in after the torch 2.11 upgrade below; it must already exist (empty is
# valid) because pip reads PIP_CONSTRAINT from the first pip call onwards.
Expand Down Expand Up @@ -577,10 +581,18 @@ RUN pip uninstall -y aiter
# The #6042, #5967 and #6007 patches are written against the gfx942/gfx950 AITER pin and
# do not apply to the older gfx1250 one (a conflict in pa_decode_sparse.py, and
# the dsv41 CSVs and the group32 GEMM do not exist there yet), so gfx1250 skips them.
# gfx950-rocm720 / gfx950-rocm724 pin aiter main 57e2c6b42e, which already has all three:
# - #6042 is merged (57e2c6b42e);
# - #5967 is merged (356c53dacd); re-applying the -U0 diff would duplicate 23 rows
# in each dsv41_fp4_*_fmoe.csv and aiter raises on duplicate keys;
# - the group32 GEMM was folded into gemm_afp8wfp8.py (#5862) with #6007 (fbbd9f6ac6)
# already in, so the sed target no longer exists.
RUN git clone ${AITER_REPO} \
&& cd aiter \
&& git checkout -f ${AITER_COMMIT} \
&& if [ "${GPU_ARCH_LIST}" != "gfx1250" ]; then \
&& if [ "${GPU_ARCH}" = "gfx950-rocm720" ] || [ "${GPU_ARCH}" = "gfx950-rocm724" ]; then \
:; \
elif [ "${GPU_ARCH_LIST}" != "gfx1250" ]; then \
git fetch origin pull/6042/head \
&& git cherry-pick --no-commit 042a289183e5b47e193df6c10160915a6e8b69f5 \
&& git fetch origin pull/5967/head \
Expand Down
Loading