Repository navigation
Conversation
murthy-l
force-pushed
the
wan2_s2v_video_api
branch
from
October 19, 2026 04:35
3c1d3f6 to
efdff92
Compare
…oject#21609) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mup_audio Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
murthy-l
force-pushed
the
wan2_s2v_video_api
branch
from
November 10, 2026 10:13
efdff92 to
adddf48
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/v1/videosrejected every Wan2.2-S2V request withTwo independent registration gaps, both only on the served path — the CLI was unaffected because
diffusion_generatorcalls the visual adjustment directly. The second one is now fixed in #43279 itself (its warmup needs it); this PR keeps the first fix and the tests for both.Changes
Wan2_2_S2V_14B_SamplingParamdeclared no video request extra fields, soaudio_path,pose_video_pathandnum_clipwere dropped from the request before validation — which then demanded the audio input that had just been discarded. Adds thevideo_request_extra_fields()override.ModelTaskType.S2Vwas absent fromis_video_gen(), so the served path skipped_adjust_visual_fields(): the output file name kept no extension (ffmpeg: "Unable to find a suitable output format") and the model's frame and fps defaults were never applied. Moved into [Feat] wan2.2-s2v: Add Wan2.2-S2V-14B speech-to-video (port of #21609) #43279 (configs/task_type.py); the invariant test below stays here.2 files, +48/−0 (
configs/sample/wan.py,test/unit/test_multiple_task_types.py).Why the second gap was reachable at all
data_type()returnsVIDEOas its fallback, so S2V claimed VIDEO output whileis_video_gen()denied it. The new test makes that class of mismatch impossible for any task, not just S2V:Testing
Three cases in
test/unit/test_multiple_task_types.py: the invariant above, plus an S2V request driven through the realvideo_apirouter over both JSON and multipart.Base
[Feat] wan2.2-s2v: Make the video API serve S2V. Rebased onto #43279's headfd32972495(main92a6910ef2). Independent of #43288 and #44427: this touches onlyconfigs/sample/wan.pyand its test, with zero file overlap with either. Merge after #43279, in any order with respect to the other two. #44441 (2-GPU server accuracy case) posts S2V requests to/v1/videos, so it needs this PR.CI States
Latest PR Test (Base): ❌ Run #42797330416
Latest PR Test (Extra): ❌ Run #42797330394
Latest PR Test (AMD ROCm 10): ❌ Run #42797330431
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: