Repository navigation
[CI] tests: Let test_hicache_storage size its host cache to the runner - #44729
Merged
Merged
Conversation
test_hicache_storage pinned a 100 GB HiCache host pool on CUDA. On the 1-gpu-small 5090 runners with 51-81 GB of host memory the server is OOM-killed at launch (exit -9), failing base-b-test-1-gpu-small (7) whenever a PR draws one of them. Without --hicache-size the default ratio applies and --hicache-host-memory-fraction reduces it to fit the machine's memory and cgroup limit. ROCm keeps its explicit 200 GB.
3 of 5 tasks
xiezhq-hermann
approved these changes
Oct 16, 2026
Collaborator
Author
|
/rerun-test registered/hicache/test_hicache_storage.py |
Contributor
|
🚀 |
Collaborator
Author
|
Verified with On main the same runner class fails with |
detain
pushed a commit
to detain/sglang
that referenced
this pull request
Oct 19, 2026
sgl-project#44729) Co-authored-by: metamergebot <metamergebot@users.noreply.github.com> (cherry picked from commit a31a8c2) (cherry picked from commit 32d9dfb8b3392ddf32608f902d747be586ac3a9c)
3 tasks done
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
base-b-test-1-gpu-small (7)fails on PRs whenever it lands on a smaller 5090 runner:test/registered/hicache/test_hicache_storage.pylaunches its server with--hicache-size 100, a fixed 100 GB pinned host pool, and on runners with roughly 51-81 GB of host memory the server is OOM-killed at launch:The same shard passes when it draws a larger runner, so affected PRs only get through by rerunning until they do. It hit four unrelated PRs on 2026-10-16 (#44583, #44533, #44613, #44614).
Modifications
On CUDA the test no longer passes
--hicache-size. With neither--hicache-sizenor--hicache-ratioset, the server uses the default host/device ratio and--hicache-host-memory-fraction(0.8 by default) reduces it until the host pools fit the machine's available memory, including the cgroup limit. The test still exercises the hierarchical cache with thefilestorage backend and the same MMLU threshold. ROCm keeps its explicit--hicache-size 200.Test plan
black,isort,ruff check --select=F401,F821,F823,UP037clean on the changed file.meta-llama/Llama-3.1-8B-Instruct) is gated on the available machine, and its environment predates main's kernel requirements. This PR's ownbase-b-test-1-gpu-small (7)runs the test on the affected 5090 runners and is the validation.CI States
Latest PR Test (Base): 🚫 Run #38891355502
Latest PR Test (Extra): ❌ Run #38891355100
Latest PR Test (AMD ROCm 10): 🚫 Run #38891355239