Skip to content

[CI] radix-cache: Drop redundant unified radix cache unit tests - #45232

Merged
hnyls2002 merged 2 commits into
mainfrom
lsyin/prune-urc-tests
Oct 19, 2026
Merged

hnyls2002 merged 2 commits into
mainfrom
lsyin/prune-urc-tests

Conversation

@hnyls2002

@hnyls2002 hnyls2002 commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator
  • Drop 34 tests from test/registered/unit/mem_cache/test_unified_radix_cache_unittest.py that cannot catch a bug another test would miss:
    • tests that restate the implementation, such as asserting the code's own raise or a constant copied from it;
    • tests whose only assertion is sanity_check, or whose assertion sits behind an if that can skip it;
    • tests whose only evidence is mock calls;
    • tests whose assertions another test already makes on the same path.
  • No behavior change; every remaining test keeps its outcome.

CI States

Latest PR Test (Base): ❌ Run #39326234095
Latest PR Test (Extra): ❌ Run #39326234006
Latest PR Test (AMD ROCm 10): ❌ Run #39326234048

@hnyls2002
hnyls2002 merged commit b20cb36 into main Oct 19, 2026
106 of 117 checks passed
@hnyls2002
hnyls2002 deleted the lsyin/prune-urc-tests branch October 19, 2026 21:20
detain added a commit to detain/sglang that referenced this pull request Oct 29, 2026
…t) SESSION 2A COMPLETE

Entry 311 records: the 9 cluster commits (2a5646b..1dc41b2) with per-
cluster batteries; the sgl-project#46954 VERDICT + hunk-by-hunk DEDUPE TABLE (sgl-project#46954
itself NEVER MERGED upstream -- sgl-project#41187's collapsed-mask re-implementation is
what arrived; (a) OURS re-planted, (b) OURS kept with the recorded UNION
REFINEMENT -- mask packs only for TRAILING spans, non-trailing collectives
BIT-IDENTICAL to upstream's shape, (c) assume_stored endpoint-proof
re-planted, (d) aux-staging alloc_len sizing re-planted = the prod-highest-
value hunk); the entry-219 PRODUCER closure (sgl-project#43727 arrived in-range as
26a1e51, the gauge-less layer DELETED per entry 219's ledger, per-pool
serving schema CONFIRMED as the only producer, docs watch-sentence
re-pointed); the entry-196 rust ADAPTER-CONTRACT repairs (mamba_value_seqlen
kwarg + parent_node_id rename -- both live TypeErrors at the merged tip);
the boot-integrity lossless-ring planting (CPU-PROVEN construction; every
caller landed with THEIRS while the pool signatures were the dropped half);
the 12 dropped storage_prefetch_lifecycle cases RE-HOMED (28P/31sub >= the
23P/28sub pin, all green unmodified against the B3-3 machinery).

GATES: ** trailing_endpoint 17P/0F PROVEN at the final tree incl. the 2-rank
gloo cases, and at every cluster checkpoint after B3-2 ** (the entry-209 DoD
gate); the B3-2/B3-caused async_ready_sync collection error CLEARED (7P);
ZERO non-environment failures remain in unit/mem_cache.

NEW PIN (per-file, CVD=9, prod venv, new post-sgl-project#45232/sgl-project#45236 layout):
unit/mem_cache 1753P/1351F/364S/4439sub/4err -> ** 1861P/1209F/364S/4514sub/
2err **; the 1209F residue is 100% env class by per-file error taxonomy:
1056F = the upstream URC-split KITS' fixtures.py build_fixture get_device()
"No accelerator" -- ENTRY 310's "the URC split files themselves are GREEN,
honest skips" CLAIM IS CORRECTED IN PLACE (its own battery log shows core
27P/465F; the kits honest-skip DEFECT is B2 scope, recorded not fixed) --
130F+2err = cargo/torch-sys (byte-identical pre-merge, the documented
environment class incl. the draft_gate 4F / joint-allocation 47F / tri-reclaim
54F storm files reclassified EXPECTED-REPLANT->ENV), 23F = the No-CUDA class
(kv_layer_router 3F + kv_storage_lifecycle 9F + kv_layer_access 5F +
pricing_property 4F + decode_retraction 2F). Named-file pins recorded
(trailing_endpoint 17P, fast_file 54P/13sub, sparse 13P/14sub EXACT, donated
17P/14sub >= 16P, fence 15P EXACT, lifecycle 28P/31sub >= 23P/28sub, ...).

CAVEATS: the merge-era top bullet ANNOTATED (B3 landed, gate met, boot ban
STAYS -- the rule's HiCache half is proven but sessions 2B/3 remain and this
batch NEVER booted, per the era rule); the entry-310 damage-map mem_cache and
trailing_endpoint rows annotated RESOLVED-AT-B3 with the F-collapse table;
the synced-block INTEGRATION OWED line annotated B3 LANDED; marker census
correction noted (tree carried 15 B3 markers, not 12; ALL consumed -- B2/B4/
B5/B6 diff-audited INTACT).

Header: STACK -> qwennext-stack-311+merge5-b3-2026-10-29; +merge5-b3 wave
tag; entries 1-311; tip -> 1dc41b2 (B3-9 = true code tip, docs above).
wanted_stack: UNTOUCHED (no S-item changed by B3 findings -- recorded here).
Debt list carried in the entry: rust cargo UNVERIFIED 932P pin (session-3
seat), entry-198 scheduler-side CATCHER cross-noted for B4, kits get_device
skip defect for B2, NVFP4 dequant-workspace deliberately NOT restored
(superseded). NOTHING PUSHED; tree clean; no GPU executed all session.
detain added a commit to detain/sglang that referenced this pull request Oct 30, 2026
… C closure -- the post-merge port queue is now decided

ARRIVAL SCAN (git log 12dc623..2a6c204 --grep) + LIVE gh STATE +
head-sha comparison for EVERY deferred item. Verdicts:
  RELEASED-BY-MERGE: sgl-project#42689 (@ 7a632cf in-range -- the SECTION-B
    cherry is now redundant; behavior note rides the restart).
  CLOSED (C-items whose PRs arrived and whose integration this stack
    performed): C1 (the dedicated merge week WAS merge sgl-project#5; all eight
    precursor PRs in-range), C2 (sgl-project#44993/sgl-project#44994 -- B5), C3 (sgl-project#45232/
    sgl-project#45236/sgl-project#45334 -- B2), C4 (sgl-project#45238/sgl-project#45241/sgl-project#45242 -- B3), C5 (sgl-project#44912/
    sgl-project#44913 -- arrived; entry-230 canary re-planted as its guard),
    C9 (sgl-project#39727 -- verified OPT-IN, no purge; BOOT_DELTA anti-needle),
    C0a (arrival shas already recorded at entry 310 -- Section C now
    carries NO open code-integration items: C6/C10 retain only their
    explicitly-named docs/boot-measurement remainders, re-stated).
  STILL-OPEN: sgl-project#44342 (head unchanged; auto-merge comfort LOST to
    #46970x), sgl-project#46153/sgl-project#37106/sgl-project#32479/sgl-project#45391 (gh CONFLICTING -- stale
    bases, rebase before any port), sgl-project#41624/sgl-project#42525/sgl-project#42660/sgl-project#44462/sgl-project#35617
    (open, heads unchanged), sgl-project#46191/sgl-project#39845-class (watch-list, none in
    range).
  HOLD STANDS (operator decision, binding): sgl-project#43356/sgl-project#46452/sgl-project#43240/
    sgl-project#43471 KV route -- step-1 'MERGE sgl-project#5 lands first' is NOW MET; the
    sequence may be re-visited ONLY with the post-merge PCIe-IPC
    measurement at an operator sitting. sgl-project#44732: the 'one purge if done
    WITH the merge' premise LAPSED when merge sgl-project#5 completed without it
    -- later execution costs the SAME single purge once; no penalty,
    no haste. Recorded for the operator, not decided by B6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant