Skip to content

Reenable ngram corpus testcase for XPU - #45489

Open
ANSHUMAN87 wants to merge 3 commits into
sgl-project:mainfrom
ANSHUMAN87:jh-ngram-tvm-ffi-added
Open

ANSHUMAN87 wants to merge 3 commits into
sgl-project:mainfrom
ANSHUMAN87:jh-ngram-tvm-ffi-added

Conversation

@ANSHUMAN87

@ANSHUMAN87 ANSHUMAN87 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  1. Reenable ngram corpus testcase for XPU
  2. Add e2e accuracy testcase for NGRAM
  3. Minor code comments updated to comply with PR changes

JH...!


CI States

Latest PR Test (Base): ❌ Run #40473474688
Latest PR Test (Extra): ❌ Run #40473474645
Latest PR Test (AMD ROCm 10): ❌ Run #40473474734

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Oct 21, 2026
@ANSHUMAN87
ANSHUMAN87 force-pushed the jh-ngram-tvm-ffi-added branch from 1c6e5bf to ba07c79 Compare October 26, 2026 06:47
@ANSHUMAN87
ANSHUMAN87 force-pushed the jh-ngram-tvm-ffi-added branch from ba07c79 to 4819eb2 Compare October 27, 2026 07:46
@ANSHUMAN87
ANSHUMAN87 force-pushed the jh-ngram-tvm-ffi-added branch from 4819eb2 to 033aba3 Compare October 27, 2026 08:26
@ANSHUMAN87
ANSHUMAN87 marked this pull request as ready for review November 2, 2026 17:30

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Required checks failed on 033aba3; this PR cannot be merged until they pass.

PR title (run)

PR title must use "[Type] scope: title" or "[Type] [Hardware] scope: title". Type must be one of: Feat, Fix, Refactor, Perf, Doc, Test, CI, Chore. Scope is required and may be any module or model name, with unrestricted letter case (letters, numbers, dots, underscores, slashes, or hyphens). Hardware is optional; use a single tag without spaces. Use uppercase hardware tags (AMD, NVIDIA, NPU, MI300X), except for exactly these four spellings: Intel, Apple, Huawei, Ascend. Reverts must use GitHub's default format: Revert "original title". Use one space between fields and after the colon, with a non-empty title and no leading or trailing whitespace. Examples: "[Fix] attention: Fix KV cache indexing", "[Feat] qwen3: Add model support", "[Perf] [AMD] flash-attn: Optimize decode performance".
Edit the title; the check reruns on its own.

@ANSHUMAN87

Copy link
Copy Markdown
Contributor Author

@mingfeima please help review, Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant