Repository navigation
Add clang-format to pre-commit config - #4583
Merged
Merged
Conversation
Contributor
Author
|
All tests have passed, cc @merrymercy |
0826joyce
pushed a commit
to 0826joyce/sglang-perf-opt
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
follow: #4194 and #4203
There is clang-format check in
pr-test-sgl-kernel.ymlnow. If the local code format doesn't meet the requirements, the CI check failsTo avoid manually running clang-format before each commit and to ensure code style consistency with the project, I added clang-format 18 checks to pre-commit configuration in SGLang.
After this PR is merged, contributors can run
pre-commit run --all-fileslocally to enforce code formatting with clang-format.Modifications
Add clang-format 18 (v18.1.8) in
.pre-commit-config.yaml, referenced the configuration in vllm.Checklist