Repository navigation
[Feat] [NVIDIA] megakernels: DSA / MLA binding view, EAGLE draft capture checks, early draft embedding sharing #46210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvrohanv
wants to merge
14
commits into
sgl-project:main
Choose a base branch
from
nvrohanv:megakernel-dsa-view-draft-capture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+716
−11
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
465a9dd
[Feat] [NVIDIA] megakernels: DSA / MLA binding view, EAGLE draft capt…
nvrohanv 1574eb8
test: consolidate megakernel DSA binding coverage
YAMY1234 77b9385
Merge branch 'main' into megakernel-dsa-view-draft-capture
nvrohanv ba86b68
[Test] [NVIDIA] megakernels: draft capture fake for megakernel API v2
nvrohanv 303e3d7
Merge branch 'main' into megakernel-dsa-view-draft-capture
nvrohanv 0219981
Merge branch 'main' into megakernel-dsa-view-draft-capture
nvrohanv 6ed6d0b
Merge branch 'main' into megakernel-dsa-view-draft-capture
YAMY1234 ade8dd4
Merge branch 'main' into megakernel-dsa-view-draft-capture
Oasis-Git 32b1244
Merge remote-tracking branch 'origin/main' into pr-46210
nvpohanh 2758ef7
[Test] spec: Stub the draft-probs vocab scatter in test_eagle_draft_e…
nvpohanh 7c0ede9
[Fix] megakernels: Fix two CI failures in the DSA view and draft capt…
nvpohanh 0828975
[Test] attention kits: Give the EAGLE draft harnesses' mock runners c…
nvpohanh cc01bc7
[Fix] megakernels: Read attn_dcp_size from the DSA backend in DsaView
nvpohanh 44b24ef
[Test] spec: Check the early embed share call site, not its exact pos…
wenscarl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[by Claude Code] Severity: functional | Confidence: High
Issue
The DSA buffers are sealed by name only (
dsa_workspace,dsa_kv_counter). An EAGLE draft builds oneDeepseekSparseAttnBackendper draft step (draft_utils.py), and each backend allocates its own_multi_ctas_kv_counter_bufferin__init__. So when the draft binding'sforward_viewreaches step 1, it sees a different counter under the same name, and_sealraisesdsa_kv_counter was reallocated after its first read. The head still has this path: only thedcp_sizefix landed.Example
GLM-5.2 NVFP4 with EAGLE and
--enable-nvidia-megakernelfails at draft CUDA graph capture, as reported in #46210 (comment).Fix
Key the DSA seal by backend, for example
(id(backend), name)with a getter for that backend. Or apply the tested minimal fix from #46210 (comment) and skip the DSA seal wheninstall_megakernelruns withis_draft=True. Add a CPU test with two backends that own different counters.