Repository navigation
[Fix] [AMD] attention: Default deterministic inference to Triton on HIP - #48083
Open
XinyuJiangCMU wants to merge 2 commits into
Open
XinyuJiangCMU wants to merge 2 commits into
XinyuJiangCMU wants to merge 2 commits into
Conversation
ROCm builds have no FA3, so deterministic inference without an attention backend failed at startup. Pick Triton on HIP instead. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
Collaborator
|
/tag-and-rerun-ci |
kevin-mii
approved these changes
Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On ROCm,
--enable-deterministic-inferencewithout--attention-backendpicks FA3, which is not available on ROCm, so the server fails to start (for example intest_return_routed_experts.py).Modifications
On HIP, pick Triton instead.
Accuracy Tests
On MI350X, a server started with only
--enable-deterministic-inferencenow starts with Triton and generates normally.Co-author-with: @JessicaJiang-123
CI States
Latest PR Test (Base): 🚫 Run #43989559859
Latest PR Test (Extra): ❌ Run #43989559441
Latest PR Test (AMD ROCm 10): ✅ Run #43989559411
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: