Repository navigation
[Test] runners: Fix the HF embedding reference for sentence-transformers 6 - #48362
Closed
dayanandav wants to merge 1 commit into
Closed
dayanandav wants to merge 1 commit into
dayanandav wants to merge 1 commit into
Conversation
…ers 6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With sentence-transformers 6,
test_embedding_modelscompares against a wrong HF reference:models.Transformerwithoutis_causal=True, so gte-Qwen2 runs bidirectionally. The kwarg was renamed (config_argstoconfig_kwargs) in v6.Modifications
test/runners.py: drop the chat-template ("message") modality for ST >= 6; passis_causal=Truewith the version's kwarg name. No-op for ST < 6.test_embedding_models.py:mem_fraction_static=0.85on XPU only, so the 8B model has enough KV for the ~6.4k-token prompt on a 24 GB card.Test-only change.
Accuracy Tests
test_embedding_models::test_prefill_logits(gte-Qwen2-1.5B, Qwen3-Embedding-8B, e5-mistral-7b) andtest_embedding_encoding_formatpass on Arc Pro B60 with sentence-transformers 6.0.1.Speed Tests and Profiling
N/A (test-only).
🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #41800310855
Latest PR Test (Extra): ❌ Run #41800310771
Latest PR Test (AMD ROCm 10): ❌ Run #41800310767
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: