Skip to content

[Fix] rust-server: Pass architectures to ModelConfig in test_rust_server_crash_dump - #49461

Merged
nvpohanh merged 1 commit into
sgl-project:mainfrom
nvpohanh:claude/ci-fix-rust-crash-dump-architectures
Nov 10, 2026
Merged

nvpohanh merged 1 commit into
sgl-project:mainfrom
nvpohanh:claude/ci-fix-rust-crash-dump-architectures

Conversation

@nvpohanh

@nvpohanh nvpohanh commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

[by Claude Code]

Motivation

Fixes #49460. #45859 made architectures a required keyword of the Rust ModelConfig constructor. test/registered/rust/test_rust_server_crash_dump.py builds ext.ModelConfig(...) directly and was not updated, so it fails on every build that includes #45859:

TypeError: ModelConfig.__new__() missing 1 required keyword argument: 'architectures'

Example failure: https://github.com/sgl-project/sglang/actions/runs/42743562575/job/129595692896

Modifications

Pass architectures=None in the test's ext.ModelConfig(...) call. The field is Option<Vec<String>>, and the test serves no real model.

Accuracy Tests

N/A (test-only change).

Speed Tests and Profiling

N/A.

Checklist

I couldn't run the test locally because it needs the built Rust extension; CI will confirm.

🤖 Generated with Claude Code


CI States

Latest PR Test (Base): ❌ Run #42759595558
Latest PR Test (Extra): ❌ Run #42759596293
Latest PR Test (AMD ROCm 10): ❌ Run #42759595899

Tip

Base CI only covers the core cases, and its workload may not exercise your change. Use /rerun-test to run the tests your change touches, or copy this prompt for an agent:

Find the registered tests this PR affects and run them with /rerun-test, following https://github.com/sgl-project/sglang/blob/main/.agents/skills/rerun-test/SKILL.md

sgl-project#45859 made `architectures` a required keyword of the Rust ModelConfig
constructor but did not update this test, which now fails with
"ModelConfig.__new__() missing 1 required keyword argument:
'architectures'". The test serves no real model, so pass None.

Fixes sgl-project#49460

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@nvpohanh

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/rust/test_rust_server_crash_dump.py

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/rust/test_rust_server_crash_dump.py  # base-b

@nvpohanh

Copy link
Copy Markdown
Collaborator Author

merge to fix CI

@nvpohanh
nvpohanh merged commit e03f9ee into sgl-project:main Nov 10, 2026
114 of 127 checks passed
nvpohanh added a commit to brandonfzhang/sglang that referenced this pull request Nov 10, 2026
nvpohanh added a commit to leejnau/sglang that referenced this pull request Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] test_rust_server_crash_dump fails on main: ModelConfig missing required 'architectures'

1 participant