Repository navigation
[Fix] rust-server: Pass architectures to ModelConfig in test_rust_server_crash_dump - #49461
Merged
nvpohanh merged 1 commit intoNov 10, 2026
Conversation
sgl-project#45859 made `architectures` a required keyword of the Rust ModelConfig constructor but did not update this test, which now fails with "ModelConfig.__new__() missing 1 required keyword argument: 'architectures'". The test serves no real model, so pass None. Fixes sgl-project#49460 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
Collaborator
Author
|
/rerun-test test/registered/rust/test_rust_server_crash_dump.py |
Contributor
|
🚀 |
Collaborator
Author
|
merge to fix CI |
nvpohanh
added a commit
to brandonfzhang/sglang
that referenced
this pull request
Nov 10, 2026
Picks up sgl-project#49461, which fixes the unrelated CI failure https://github.com/sgl-project/sglang/actions/runs/42743562575/job/129595692896 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nvpohanh
added a commit
to leejnau/sglang
that referenced
this pull request
Nov 10, 2026
Picks up sgl-project#49461, which fixes the unrelated CI failure https://github.com/sgl-project/sglang/actions/runs/42744192716/job/129641945789 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 5 tasks
Merged
4 of 5 tasks
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[by Claude Code]
Motivation
Fixes #49460. #45859 made
architecturesa required keyword of the RustModelConfigconstructor.test/registered/rust/test_rust_server_crash_dump.pybuildsext.ModelConfig(...)directly and was not updated, so it fails on every build that includes #45859:Example failure: https://github.com/sgl-project/sglang/actions/runs/42743562575/job/129595692896
Modifications
Pass
architectures=Nonein the test'sext.ModelConfig(...)call. The field isOption<Vec<String>>, and the test serves no real model.Accuracy Tests
N/A (test-only change).
Speed Tests and Profiling
N/A.
Checklist
I couldn't run the test locally because it needs the built Rust extension; CI will confirm.
🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #42759595558
Latest PR Test (Extra): ❌ Run #42759596293
Latest PR Test (AMD ROCm 10): ❌ Run #42759595899
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: