Repository navigation
Conversation
Reject QSA verification windows above the current backend limit during argument resolution, after normalization and including adaptive maxima. Add registered CPU regression coverage for boundary values, normalized windows, adaptive maxima, and non-QSA configurations. Partially addresses sgl-project#44099.
This was referenced Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
QSA currently rejects speculative verification windows larger than the indexer compression ratio at runtime, after model weights have been loaded.
This PR moves the validation to server argument resolution, providing an early and actionable error for unsupported configurations.
Partially addresses #44099.
Modifications
_validate_qsa_speculative_window()to validate the maximum effective draft-token count against the QSA compression ratio.max_speculative_num_draft_tokens()helper.Accuracy Tests
CPU-only validation; no model forward or attention kernel changes.
git diff --check: passed.No end-to-end GPU inference accuracy tests were performed.
Speed Tests and Profiling
Not applicable. This PR adds startup argument validation only and does not modify the inference execution path or attention kernels.
Scope and Related Work
Checklist
CI States
Latest PR Test (Base): ❌ Run #43038726361
Latest PR Test (Extra): ❌ Run #43038726023
Latest PR Test (AMD ROCm 10): ❌ Run #43038726258
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: