Repository navigation
[Chore] [AMD] mono-kernel: Pin sgl-amd-mono at a04ceab for Qwen3.5 FP8 - #50813
Merged
Merged
Conversation
The ROCm image installs this pin, and a04ceab is the merge of sgl-amd-mono#58, which adds qwen35_a17b.
HaiShaw
approved these changes
Nov 16, 2026
HaiShaw
enabled auto-merge (squash)
November 16, 2026 17:19
5 tasks done
HaiShaw
disabled auto-merge
November 16, 2026 23:42
HaiShaw
enabled auto-merge (squash)
November 16, 2026 23:42
HaiShaw
disabled auto-merge
November 16, 2026 23:42
kevin-mii
added a commit
that referenced
this pull request
Nov 17, 2026
Brings in day-0's c15 catch-up (main up to d79c53c) and two day-0 fixes. One conflict: the sgl-amd-mono pin takes main's a04ceab (#50813), which is 8 commits ahead of the K3.1 pin b9f40eb562 and leaves its kimi_k3 / kimi_k31 monokernels unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The ROCm image installs
sgl-amd-monoat the commit pinned inpython/pyproject_other.toml. That pin is7113024f(2026-11-09). sgl-project/sgl-amd-mono#58 merged later, on 2026-11-16, and addsqwen35_a17bfor Qwen3.5-397B-A17B-FP8. A daily image built from the current pin, includinglmsysorg/sglang-rocm:v0.5.23-rocm720-mi35x-20261116, therefore does not contain that spec, and--enable-amd-monokerneldoes not serve it.Modifications
sgl-amd-monoata04ceab159d9d8bb43403f96485337f35fbb59c3, which issgl-amd-monomain and the merge of Update README.md #58.docker/rocm.Dockerfilechecks out this same pin, so the Dockerfile does not change.Accuracy Tests
This PR does not change SGLang code. Accuracy for
qwen35_a17bis reported on sgl-amd-mono#58 and was not rerun against this pin.Checklist
Review and Merge Process
CI States
Latest PR Test (Base): ✅ Run #43981673461
Latest PR Test (Extra): ❌ Run #43981673372
Latest PR Test (AMD ROCm 10): ❌ Run #43981673366
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: