Skip to content

[Chore] [AMD] mono-kernel: Pin sgl-amd-mono at a04ceab for Qwen3.5 FP8 - #50813

Merged
HaiShaw merged 2 commits into
sgl-project:mainfrom
yichiche:amd/pin-sgl-amd-mono-a04ceab
Nov 16, 2026
Merged

HaiShaw merged 2 commits into
sgl-project:mainfrom
yichiche:amd/pin-sgl-amd-mono-a04ceab

Conversation

@yichiche

@yichiche yichiche commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The ROCm image installs sgl-amd-mono at the commit pinned in python/pyproject_other.toml. That pin is 7113024f (2026-11-09). sgl-project/sgl-amd-mono#58 merged later, on 2026-11-16, and adds qwen35_a17b for Qwen3.5-397B-A17B-FP8. A daily image built from the current pin, including lmsysorg/sglang-rocm:v0.5.23-rocm720-mi35x-20261116, therefore does not contain that spec, and --enable-amd-monokernel does not serve it.

Modifications

  • Pin sgl-amd-mono at a04ceab159d9d8bb43403f96485337f35fbb59c3, which is sgl-amd-mono main and the merge of Update README.md #58. docker/rocm.Dockerfile checks out this same pin, so the Dockerfile does not change.

Accuracy Tests

This PR does not change SGLang code. Accuracy for qwen35_a17b is reported on sgl-amd-mono#58 and was not rerun against this pin.

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.

CI States

Latest PR Test (Base): ✅ Run #43981673461
Latest PR Test (Extra): ❌ Run #43981673372
Latest PR Test (AMD ROCm 10): ❌ Run #43981673366

Tip

Base CI only covers the core cases, and its workload may not exercise your change. Use /rerun-test to run the tests your change touches, or copy this prompt for an agent:

Find the registered tests this PR affects and run them with /rerun-test, following https://github.com/sgl-project/sglang/blob/main/.agents/skills/rerun-test/SKILL.md

The ROCm image installs this pin, and a04ceab is the merge of sgl-amd-mono#58, which adds qwen35_a17b.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@HaiShaw
HaiShaw merged commit 01f9bbb into sgl-project:main Nov 16, 2026
132 of 145 checks passed
kevin-mii added a commit that referenced this pull request Nov 17, 2026
Brings in day-0's c15 catch-up (main up to d79c53c) and two day-0
fixes. One conflict: the sgl-amd-mono pin takes main's a04ceab (#50813),
which is 8 commits ahead of the K3.1 pin b9f40eb562 and leaves its
kimi_k3 / kimi_k31 monokernels unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants