Skip to content

Fix GGuf and add back test_gguf.py #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

Fridge003
Copy link
Collaborator

Motivation

Close #7012

Modifications

Checklist

@Fridge003
Copy link
Collaborator Author

cc @zhyncs

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Fridge003, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues with loading GGUF quantized models. The core changes involve modifying how quantized weights are handled during the model loading phase, specifically by deferring or adding a post-loading processing step. This fix allows the previously disabled GGUF test suite to be re-enabled, ensuring correct functionality for GGUF models.

Highlights

  • GGUF Loading Fix: Implemented a fix for loading GGUF quantized models by adjusting the weight processing logic during model initialization.
  • Post-Loading Weight Processing: Introduced a new step in the model loading process to call process_weights_after_loading on quantized modules after the initial weights are loaded.
  • Test Suite Update: Re-enabled the test_gguf.py test file in the vllm_dependency_test suite, which was previously commented out.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GGUF model loading by centralizing the finalization of quantized weights to the process_weights_after_loading method. The re-enablement of GGUF tests supports the correctness of this fix.

Copy link
Member

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@zhyncs zhyncs added high priority ready-to-merge The PR is ready to merge after the CI is green. labels Jun 10, 2025
@Fridge003 Fridge003 merged commit 2a5f010 into sgl-project:main Jun 11, 2025
254 of 275 checks passed
almaslof pushed a commit to mpashkovskii/sglang that referenced this pull request Jun 11, 2025
@Fridge003 Fridge003 deleted the gguf branch June 11, 2025 17:49
jianan-gu pushed a commit to jianan-gu/sglang that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority ready-to-merge The PR is ready to merge after the CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix GGuf feature on latest main
2 participants