Repository navigation
Fix metrics collection with data parallelism - #7645
ngoyal2707 wants to merge 1 commit into
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Summary of Changes
Hello @ngoyal2707, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with metrics collection in data parallel environments. My changes ensure that metrics are correctly associated with their specific data parallelism rank, providing more accurate and granular insights into system performance when running distributed models.
Highlights
- Metrics Initialization: I've introduced a new
metrics_dp_rankattribute within theSchedulerto correctly determine the data parallelism rank for metric reporting. This accounts for both regular data parallelism and attention data parallelism modes. - Enhanced Metrics Labels: I've updated the
init_metricsmethod to include thedp_rankas a label for all collected metrics. This ensures that metrics are properly attributed to their respective data parallelism ranks, improving observability in distributed setups.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes metrics collection for data parallelism by adding a dp_rank label to the metrics. It introduces metrics_dp_rank to handle cases where data parallel attention is enabled or disabled, ensuring correct metric reporting. A suggestion was made to improve error handling for cases where dp_rank is unexpectedly None.
|
@ngoyal2707 Hi, I think this PR will address your issue: #7597 |
h/t claude code