Skip to content

Update the base image of the docker - #900

Merged
Ying1123 merged 1 commit into
mainfrom
docker-test
Aug 3, 2024
Merged

Ying1123 merged 1 commit into
mainfrom
docker-test

Conversation

@Ying1123

@Ying1123 Ying1123 commented Aug 3, 2024 •

Copy link
Copy Markdown
Contributor

Previous build with ubuntu 22.04 is not compatible with some user's dev environment. Specifically, ubuntu 22.04 with openssl 3.x breaks access to aws S3.

@Ying1123
Ying1123 force-pushed the docker-test branch 2 times, most recently from c2ef0c6 to 989e7df Compare August 3, 2024 03:40
@Ying1123
Ying1123 merged commit 001b0bd into main Aug 3, 2024
@Ying1123
Ying1123 deleted the docker-test branch August 3, 2024 04:55
@Ying1123 Ying1123 mentioned this pull request Aug 3, 2024
3 tasks done
@Ying1123 Ying1123 linked an issue Aug 3, 2024 that may be closed by this pull request
3 tasks done
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
McZyWu pushed a commit to McZyWu/sgl-sglang that referenced this pull request Jul 2, 2026
Update nightly-test-npu-e2e-single-node.yml
efschu pushed a commit to efschu/htsglang that referenced this pull request Aug 26, 2026
…alue match

sgl-project#797 layered two matching modes and returned out of the first one. A
declared provenance naming an investigation that is NOT in the retraction
register hit `return by_investigation(declared)` -> None, and mode 2's
value match never ran. So the shipped 29,19,16 -- from retracted sgl-project#602, the
vector the whole gate exists for -- passed under any unrelated lineage.

Not an exotic input. The env twin SGLANG_UNEVEN_TOKEN_VECTOR_PROVENANCE
outlives the process that set it, so one earlier launch in the same shell
disarms every later one. The gate protects the tree-spec-DCP class from
serving on withdrawn evidence; a value-blind gate protects nothing.

FIX DIRECTION: the modes ADD, they do not replace. Mode 1 may convict a
vector whose value looks innocent; it may never acquit one whose value does
not. A declared, non-retracted provenance now falls THROUGH to the value
match instead of returning.

SCOPE, and the boundary is deliberate rather than an oversight.
PROVENANCE_MEASURED keeps its short-circuit. It names no investigation --
it asserts that this boot profiled the value itself -- so a value match
there would refuse a measurement for resembling the withdrawn estimate it
replaced. That exemption is sgl-project#797's own and is tested directly at
test_retracted_vector_boot_refusal_797.py::TestWhatMustNotBeRefused797;
widening past it would have turned a green sibling red, which is a
different ticket, not this one. Named here rather than changed silently.

RED FIRST, both axes. Before the fix: 6 failed / 6 passed -- the 6 red are
the new-behaviour cases, the 6 green are mode 1, the no-false-positive side
and the measured exemption, so the file is not blanket-red. After: 36
passed across the new suite plus both sgl-project#797 suites (boot refusal, seed
liveness), i.e. the widened refusal regresses neither sibling.

THE MUTANT, as the ticket names it: provenance = 'sgl-project#797' (real, not
retracted) over vector 29,19,16 (retracted). Caught, at the predicate and
at the boot path through resolve_cp_token_ratios -- sgl-project#182's rule, a gate no
boot arrives at is not a gate. The gcd-written form 58,38,32 is caught on
the same path, so the fix is not one rewrite wide.

CLASS SWEEP. The shape is "a declared lineage short-circuits a value
check". planner/rejected.py, the register next door, has no provenance
concept at all and cannot carry it. distributed/utils.py:690 reads like the
same shape and is not: it is the env-over-flag fallback that PRODUCES the
declaration, and None there arms the value match rather than disarming it.
retracted.py was the only instance.

Two comments the fix made false are corrected in the same commit: the
module docstring's "mode 1 short-circuits before any value comparison
happens" and mode 2's description as the UNDECLARED-provenance mode.

This branch was previously deployed

1 inactive deployment
prod — 71bdf136 Deployed Aug 3, 2024 by Ying1123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fail to build from Docker

1 participant