Skip to content

Fix CI && python3.8 compatible - #920

Merged
hnyls2002 merged 4 commits into
mainfrom
fix-ci
Aug 4, 2024
Merged

hnyls2002 merged 4 commits into
mainfrom
fix-ci

Conversation

@hnyls2002

@hnyls2002 hnyls2002 commented Aug 4, 2024 •

Copy link
Copy Markdown
Collaborator

Motivation

  1. Fix the CI port problem and make the annotation compatible with python3.8. list[int] is not allowed in python<=3.8
  2. Kill the running server by the port.
  3. unittest default port from 30000 -> 8157

@hnyls2002
hnyls2002 marked this pull request as draft August 4, 2024 22:30
@hnyls2002
hnyls2002 marked this pull request as ready for review August 4, 2024 23:00
@hnyls2002
hnyls2002 merged commit bb66cc4 into main Aug 4, 2024
@hnyls2002
hnyls2002 deleted the fix-ci branch August 4, 2024 23:02
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
cherryblo added a commit to cherryblo/sglang-project that referenced this pull request Jul 2, 2026
efschu pushed a commit to efschu/htsglang that referenced this pull request Aug 27, 2026
…address the bound pool, and sgl-project#912's remainder: live double-claims read at check time) into the flip train
efschu pushed a commit to efschu/htsglang that referenced this pull request Aug 27, 2026
`--verify` named exactly one new module,
test/registered/unit/mem_cache/test_pool_invariant_live_double_912b.py, and
no sha256 among the 184 already in the table moved. `test_seam_extent_
contract_783.py` DID change bytes, but it sits in the managers table's
long-standing unclassified set, so no fast-lane proof went stale with it --
PARALLEL stayed at 270 there, checked rather than assumed.

MEASURED on this tip, hermetic (CUDA_VISIBLE_DEVICES=""):
  * fresh serial reference, 185 modules, one process, one order:
    2 failed / 2761 passed / 927 skipped, 164.8s. 2761 = 2745 + exactly the
    16 the new module contributes; the 2 failures are the same two
    test_acceptance_emitters_758.py::RefillTiming names, compared as a LIST.
  * the 184 solo logs carried forward, plus one new solo probe.
  Demotions: ZERO, counted by diffing the table's own rows before and after.

  before  PARALLEL 171  RANKS 13  UNCLASSIFIED 1
  after   PARALLEL 172  RANKS 13  SERIAL 0  EXCLUDED 0   -> VERIFY OK

gate_partition.tsv (managers) again NOT rebuilt, for the reason recorded in
Train-2c: its 35-module gap has no surviving solo logs, so a rebuild would
demote 270 proven rows to make two new ones look better. sgl-project#920's module and
sgl-project#917's before it therefore run in the serial lane by the default-for-the-
unknown rule, both named in the runner's report, and the lane's arithmetic
shows it: 617 -> 630 passed, which is exactly the new module's 13. The
adapted sgl-project#783 contract contributes 0 to that delta -- 11 passed on this tip
and 11 on 3502a9a, measured on both, so pinning the DECISION instead of
the literal changed what the tests assert without changing how many there
are.

gate_partition_scheduler.tsv untouched: seam_census_double.py is a harness,
not a test_*.py, so it carries no table row.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants