Remove usage/recommendation of baseUrl.
#7342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielRosenwasser is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
andrewbranch
approved these changes
May 5, 2025
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@/*": ["./src/*"] |
There was a problem hiding this comment.
By the way, why does the "solution"/"workspace root" tsconfig.json need to have this configured? What depends on the options in this tsconfig.json? I would think only tsconfig.app.json needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While many developers assume that
baseUrlis a requirement to usepaths, that hasn't been the case for a few years (see this pull request here).Using
baseUrlisn't recommended because it allows developers to accidentally resolve directly via thebaseUrloverpaths. Additionally, the TypeScript team plans to deprecatebaseUrlin 6.0, with no support in 7.0 (the native port of TypeScript).This PR removes usage of
baseUrlintsconfig.jsonfiles and removes recommendations of it from the documentation.