Skip to content

Upgrade to rails/webpacker v6 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 11, 2021
Merged

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Dec 28, 2020

  • Refactored code to use new merge capabilities of webpacker v6

Testing

  • Basics
  • HMR for JS
  • HMR for CSS

@justin808 justin808 force-pushed the justin808/update-webpacker-v-6 branch from 7fbb7c9 to 2b2a4c2 Compare December 28, 2020 10:15
@justin808
Copy link
Member Author

justin808 commented Dec 28, 2020

HMR seems broken for JS.

Maybe this will help: pmmmwh/react-refresh-webpack-plugin#252

@justin808
Copy link
Member Author

Let's update.

@justin808 justin808 force-pushed the justin808/update-webpacker-v-6 branch from d4cc2c8 to 87fc55c Compare April 25, 2021 22:50
@justin808
Copy link
Member Author

@Judahmeek should we merge?

Copy link
Member Author

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- just remove debugging and let's merge!

@Judahmeek Judahmeek merged commit 42b3c3d into master May 11, 2021
@Judahmeek Judahmeek deleted the justin808/update-webpacker-v-6 branch May 11, 2021 00:11
@justin808 justin808 restored the justin808/update-webpacker-v-6 branch May 11, 2021 06:15
@justin808 justin808 deleted the justin808/update-webpacker-v-6 branch May 11, 2021 06:16
justin808 added a commit that referenced this pull request May 11, 2021
* Upgrade to rails/webpacker v6

* Refactored code to use new merge capabilities of webpacker v6

* Updated to webpacker v6.beta.7 and React on Rails 12.2.0

Co-authored-by: Judah Meek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants