-
Notifications
You must be signed in to change notification settings - Fork 24
Upgrade to rails/webpacker v6 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fbb7c9
to
2b2a4c2
Compare
HMR seems broken for JS. Maybe this will help: pmmmwh/react-refresh-webpack-plugin#252 |
justin808
commented
Feb 11, 2021
Let's update. |
* Refactored code to use new merge capabilities of webpacker v6
d4cc2c8
to
87fc55c
Compare
@Judahmeek should we merge? |
justin808
commented
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome -- just remove debugging and let's merge!
justin808
added a commit
that referenced
this pull request
May 11, 2021
* Upgrade to rails/webpacker v6 * Refactored code to use new merge capabilities of webpacker v6 * Updated to webpacker v6.beta.7 and React on Rails 12.2.0 Co-authored-by: Judah Meek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing