Skip to content

[Repo Assist] feat: navigate filtered list with arrow keys without leaving filter mode#153

Draft
github-actions[bot] wants to merge 1 commit intomainfrom
repo-assist/feat-filter-navigate-2026-04-25-ed930589365b0996
Draft

[Repo Assist] feat: navigate filtered list with arrow keys without leaving filter mode#153
github-actions[bot] wants to merge 1 commit intomainfrom
repo-assist/feat-filter-navigate-2026-04-25-ed930589365b0996

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

🤖 This PR was created by Repo Assist, an automated AI assistant.

What

Allows / / PgUp / PgDn / Home / End to navigate the package list while the LocalFilter prompt is active (Installed / Upgrades views).

Before: All navigation keys were silently ignored in LocalFilter mode. The user had to press Enter to exit the prompt first, then navigate.

After: The cursor moves immediately while typing the filter — the filter text is preserved, only the selection changes. Pressing Esc or Enter still works exactly as before.

Why

Popular TUI filter prompts (fzf, Telescope, Vim's / search) all let you navigate results without leaving the input field. The previous behaviour was a friction point: you'd type a filter to narrow the list, then have to press Enter before you could select the package you wanted.

Change

handle_local_filter_input in src/handler.rs gains six new match arms for the navigation keys, each using the same logic as the equivalent arms in handle_normal_mode. No existing behaviour is changed.

Test Status

cargo check --all-targets  → clean
cargo fmt -- --check       → clean
cargo clippy -- -D warnings → clean
cargo test                 → 232 passed (was 230) — 2 new tests:
  - local_filter_up_down_navigate_without_leaving_filter_mode
  - local_filter_home_end_navigate_to_bounds

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist · ● 5.6M ·

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@cbb46ab386962aa371045839fc9998ee4e97ca64

…r mode

Previously, all navigation keys were silently ignored while the local
filter input was active, requiring the user to press Enter before they
could move the cursor. This is unintuitive — in most TUI filter prompts
(fzf, telescope, etc.) you can navigate results without leaving the
input field.

This commit adds Up/Down/PageUp/PageDown/Home/End handlers to
handle_local_filter_input so the selection can be moved while still in
filter mode. The filter text is preserved; only the cursor position
changes. No existing behaviour is affected.

Two regression tests are added:
- local_filter_up_down_navigate_without_leaving_filter_mode
- local_filter_home_end_navigate_to_bounds

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants