Refactor and fix logic of multiple vs single select#164
Merged
shentao merged 3 commits intoshentao:2.0from Jan 8, 2017
Merged
Conversation
pczarn
force-pushed
the
refactor-and-fix
branch
3 times, most recently
from
87e9980 to
d3de040
Compare
|
@shentao what's the status? :D |
Owner
|
Will merge during Xmas! |
pczarn
force-pushed
the
refactor-and-fix
branch
from
a38bea5 to
2cb9c95
Compare
A bug where valueKeys tried to access an attribute on null is fixed. The `remove` event is emitted when the value is deselected in single select.
pczarn
force-pushed
the
refactor-and-fix
branch
2 times, most recently
from
dc71797 to
b574bdd
Compare
pczarn
force-pushed
the
refactor-and-fix
branch
from
b574bdd to
102a1e2
Compare
Owner
|
Surprise surprise – merged! I will ship the new release tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug where valueKeys tried to access an attribute on null is fixed.
The
removeevent is emitted when the value is deselectedin single select.