Closed
Conversation
|
Is there a workaround for this issue or can this be merged in so that this fix now works when there are no options found by the search? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1636 where the "List is empty" message doesn't display when all options are selected in a multiselect component with the hideSelected prop enabled. The fix changes the visibility condition from checking the original options array to checking filteredOptions, which accounts for filtering logic including hiding selected items.
Changes:
- Updated the condition for displaying the "List is empty" message to use
filteredOptions.lengthinstead ofoptions.length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Closing PR as this is targeting an old branch, not master. I've put the changes on a new PR: #1926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now by default list is empty will be show on selecting all the options from the list
This is a new pull request (Closed PR #1699 ) after rebasing to next from master.
Closes Issue #1636