fix: Make the selected item(s) in dropdown get read out the screen reader when focused#1734
Merged
mattelen merged 2 commits intoshentao:masterfrom Sep 12, 2024
Merged
Conversation
anthonymuau
changed the title
|
This would be very helpful, thank you |
…ia-selected-item # Conflicts: # src/Multiselect.vue
mattelen
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address a bug in vue-multiselect where if a user is using a screen reader, the selected state of the items are not read out when the user focuses on them.
Steps to reproduce
Expected behavior: The screen reader should announce the selected item and its selected state.
Actual behavior: The screen reader remains silent, failing to announce the selected item or its selected state.