Skip to content

Add required prop#1746

Merged
mattelen merged 3 commits intoshentao:masterfrom
Shamus03:patch-1
Jul 11, 2024
Merged

Add required prop#1746
mattelen merged 3 commits intoshentao:masterfrom
Shamus03:patch-1

Conversation

@Shamus03
Copy link
Copy Markdown
Contributor

Ability to set the required attribute on the HTML input element. This is useful when using modern browsers' builtin form validation.

Ability to set the `required` attribute on the HTML input element.  This is useful when using modern browsers' builtin form validation.
Was using undefined to completely omit the `required` attribute unless requested, but false works too.
Copy link
Copy Markdown

@wasiqwiqar wasiqwiqar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward and simple, was just looking for this in my current project

Copy link
Copy Markdown

@ZS-Andisch ZS-Andisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and important change

@akki-jat
Copy link
Copy Markdown
Collaborator

akki-jat commented May 7, 2024

@Shamus03 Please resolve the merge conflict.

@akki-jat
Copy link
Copy Markdown
Collaborator

akki-jat commented May 7, 2024

@mattelen We can add this simple improvement now as we have released the v3.

@Shamus03
Copy link
Copy Markdown
Contributor Author

Shamus03 commented May 7, 2024

@Shamus03 Please resolve the merge conflict.

Done!

@mattelen mattelen merged commit 47f3685 into shentao:master Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants